From d18293c6adbb84f3afa0404db7c1697f562c992a Mon Sep 17 00:00:00 2001 From: Lorenz Leutgeb Date: Wed, 12 Aug 2026 16:12:21 +0200 Subject: [PATCH] cli/test: Do not accidentally test `rad debug` The tests `rad-warn-ipv6.md` and `rad-warn-old-nodes.md` are meant to primarily test the output of warnings. They test the output twice, via `rad debug` and via `rad node status`. Testing the output via one command should be sufficient. --- crates/radicle-cli/examples/rad-warn-ipv6.md | 42 +----------------- .../examples/rad-warn-old-nodes.md | 43 +------------------ 2 files changed, 2 insertions(+), 83 deletions(-) diff --git a/crates/radicle-cli/examples/rad-warn-ipv6.md b/crates/radicle-cli/examples/rad-warn-ipv6.md index c9922ed95..df381a775 100644 --- a/crates/radicle-cli/examples/rad-warn-ipv6.md +++ b/crates/radicle-cli/examples/rad-warn-ipv6.md @@ -7,47 +7,7 @@ $ rad config push node.externalAddresses 2001:db8::3:8776 2001:db8::3:8776 ``` -Note the warnings that the above configuration causes: - -``` -$ rad debug -{ - "radExe": "[..]", - "radVersion": "[..]", - "radicleNodeVersion": "radicle-node [..]", - "gitRemoteRadVersion": "git-remote-rad [..]", - "gitVersion": "git version [..]", - "sshVersion": "[..]", - "gitHead": "[..]", - "log": { - "filename": "[..]", - "exists": false, - "len": null - }, - "oldLog": { - "filename": "[..]", - "exists": false, - "len": null - }, - "operatingSystem": "[..]", - "arch": "[..]", - "env": { - "PATH": "[..]", - "RAD_HOME": "[..]", - "RAD_KEYGEN_SEED": "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", - "RAD_LOCAL_TIME": "[..]", - "RAD_PASSPHRASE": "", - "RAD_RNG_SEED": "0" - }, - "warnings": [ - "Value of configuration option `preferredSeeds` at zero-based index 0 mentions IPv6 address '2001:db8::1' without square brackets. The address format will change, and this address will be rejected in the future. Please edit your configuration file to enclose the IPv6 address in square brackets. Combined with port information it should read '[2001:db8::1]:8776'. Refer to RFC 5926, Sec. 6 as well as RFC 3986, Sec. D.1. and RFC 2732, Sec. 2.", - "Value of configuration option `node.connect` at zero-based index 0 mentions IPv6 address '2001:db8::2' without square brackets. The address format will change, and this address will be rejected in the future. Please edit your configuration file to enclose the IPv6 address in square brackets. Combined with port information it should read '[2001:db8::2]:8776'. Refer to RFC 5926, Sec. 6 as well as RFC 3986, Sec. D.1. and RFC 2732, Sec. 2.", - "Value of configuration option `node.externalAddresses` at zero-based index 0 mentions IPv6 address '2001:db8::3' without square brackets. The address format will change, and this address will be rejected in the future. Please edit your configuration file to enclose the IPv6 address in square brackets. Combined with port information it should read '[2001:db8::3]:8776'. Refer to RFC 5926, Sec. 6 as well as RFC 3986, Sec. D.1. and RFC 2732, Sec. 2." - ] -} -``` - -Also, `rad node status` will warn us: +Note the warnings that the above configuration causes when running `rad node status`: ``` $ rad node status diff --git a/crates/radicle-cli/examples/rad-warn-old-nodes.md b/crates/radicle-cli/examples/rad-warn-old-nodes.md index a305f9513..2491b5dda 100644 --- a/crates/radicle-cli/examples/rad-warn-old-nodes.md +++ b/crates/radicle-cli/examples/rad-warn-old-nodes.md @@ -11,48 +11,7 @@ z6MkrLMMsiPWUcNPHcRajuMi9mDfYckSoJyPwwnknocNYPm7@seed.radicle.garden:8776 z6Mkmqogy2qEM2ummccUthFEaaHvyYmYBYh3dbe9W4ebScxo@rosa.radicle.xyz:8776 ``` -Note the warnings that the above configuration causes: - -``` -$ rad debug -{ - "radExe": "[..]", - "radVersion": "[..]", - "radicleNodeVersion": "radicle-node [..]", - "gitRemoteRadVersion": "git-remote-rad [..]", - "gitVersion": "git version [..]", - "sshVersion": "[..]", - "gitHead": "[..]", - "log": { - "filename": "[..]", - "exists": false, - "len": null - }, - "oldLog": { - "filename": "[..]", - "exists": false, - "len": null - }, - "operatingSystem": "[..]", - "arch": "[..]", - "env": { - "PATH": "[..]", - "RAD_HOME": "[..]", - "RAD_KEYGEN_SEED": "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", - "RAD_LOCAL_TIME": "[..]", - "RAD_PASSPHRASE": "", - "RAD_RNG_SEED": "0" - }, - "warnings": [ - "Value of configuration option `node.connect` at index 0 mentions node with hostname 'ash.radicle.garden', which has been renamed to 'rosa.radicle.network'. Please edit your configuration file to use the new address.", - "Value of configuration option `node.connect` at index 1 mentions node with hostname 'iris.radicle.xyz', which has been renamed to 'iris.radicle.network'. Please edit your configuration file to use the new address.", - "Value of configuration option `preferredSeeds` at index 0 mentions node with hostname 'seed.radicle.garden', which has been renamed to 'iris.radicle.network'. Please edit your configuration file to use the new address.", - "Value of configuration option `preferredSeeds` at index 1 mentions node with hostname 'rosa.radicle.xyz', which has been renamed to 'rosa.radicle.network'. Please edit your configuration file to use the new address." - ] -} -``` - -Also, `rad node status` will warn us: +Note the warnings that the above configuration causes when running `rad node status`: ``` $ rad node status