mirror of
https://seed.radicle.dev/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5.git
synced 2026-11-21 02:20:43 +08:00
Plenty conservative `debug_assert!`s, cause panics as soon as two actions that should be added to the timeline appear within the same operation. But there is no code in place to prevent this. It also does not seem to be problematic to visit the same operation multiple times (once per contained action). A set that retains iteration order does the job. Analysis of this bug was done over Zulip, see <https://radicle.zulipchat.com/#narrow/channel/369873-Support/topic/radicle-node.201.2E10.20segfaults/with/616991470>. `Update::Reviewed::review` is boxed due to: error: large size difference between variants --> crates/radicle-cli/src/terminal/patch/timeline.rs:158:1 | 158 | / enum Update<'a> { 159 | | /// A revision of the patch was reviewed. 160 | | Reviewed { review: Review }, | | --------------------------- the largest variant contains at least 352 bytes 161 | | /// A revision of the patch was merged. 162 | |/ Merged { 163 | || author: Author<'a>, 164 | || /// If the merge is none, this means that it was a fast-forward merge. 165 | || merge: Option<Merge>, 166 | || }, | ||_____- the second-largest variant contains at least 120 bytes 167 | | } | |__^ the entire enum is at least 352 bytes