Daniel Norman and Lorenz Leutgeb
4867917f37
radicle/canonical: Remove RawRules::matches
...
Testing revealed that the implementation violated RIP-0006, which
requires the most specific rule matching the target of `HEAD`
to use an `allow` of `delegates` and the document threshold.
`validate_head_rule` took the first match from `RawRules`, which orders
patterns lexicographically, so a glob could be validated in place of the
rule that actually governs the branch.
The issue here is that the correct order for matching patterns is only
guaranteed on `Rules`, but not on `RawRules`.
To prevent such errors in the future, remove `RawRules::matches`. This
requires some refactoring, and makes synthesis of the default branch
rule slightly less efficient in the worst case, but we are willing to
take that hit for a cleaner implementation.
Co-authored-by: Lorenz Leutgeb <lorenz.leutgeb@radicle.dev >
2026-09-01 19:41:02 +02:00
..
2025-10-13 08:56:23 +01:00
2026-09-01 19:41:02 +02:00
2026-06-09 11:37:26 +02:00
2025-09-26 12:03:01 +01:00
2026-04-30 15:50:29 -04:00
2026-06-20 10:01:40 +01:00
2025-10-17 16:57:29 +01:00
2026-05-28 16:52:02 +01:00
2026-08-30 17:37:09 +02:00
2025-06-09 15:09:21 +02:00
2025-06-09 15:09:21 +02:00
2025-06-09 15:09:21 +02:00
2026-04-30 15:50:29 -04:00
2026-04-30 15:50:29 -04:00
2026-04-17 17:15:31 +01:00
2026-02-16 21:39:11 +01:00
2025-07-18 21:44:06 +01:00
2026-07-21 09:19:01 +02:00
2026-03-17 10:31:29 +00:00
2025-06-09 15:09:21 +02:00
2026-04-17 17:15:31 +01:00
2026-06-09 11:00:32 +02:00
2025-06-09 15:09:21 +02:00
2025-06-09 15:09:21 +02:00
2025-06-09 15:09:21 +02:00
2025-08-19 15:01:26 +01:00
2026-06-09 11:00:32 +02:00
2025-06-09 15:09:21 +02:00
2026-06-09 11:37:26 +02:00
2026-07-17 17:05:11 +02:00
2026-06-03 11:49:41 +02:00
2026-02-16 21:39:11 +01:00
2026-04-30 15:50:29 -04:00
2026-04-27 18:34:30 +02:00
2026-04-30 15:50:29 -04:00
2026-08-04 19:34:34 +02:00
2026-08-04 19:34:34 +02:00
2025-07-16 16:41:16 +02:00
2025-06-09 15:09:21 +02:00
2026-05-22 09:09:01 +01:00
2026-01-22 10:38:28 +00:00
2026-05-22 09:09:01 +01:00
2026-05-22 09:09:01 +01:00
2026-05-28 16:52:02 +01:00
2026-05-28 16:52:02 +01:00
2025-07-23 07:43:27 +01:00
2026-05-28 16:52:02 +01:00
2026-05-28 16:52:02 +01:00
2025-07-23 07:43:27 +01:00
2026-06-22 16:52:53 +01:00
2026-03-17 11:39:09 +00:00
2026-03-17 11:39:09 +00:00
2026-06-22 16:52:53 +01:00
2025-07-18 21:44:06 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-06-22 16:52:53 +01:00
2026-04-17 17:15:31 +01:00
2026-03-24 14:40:42 +00:00
2025-09-28 18:02:55 +02:00
2026-03-12 13:30:09 +00:00
2025-09-26 13:21:38 +02:00
2025-08-04 17:00:54 +02:00
2025-08-04 17:00:54 +02:00
2026-06-09 11:37:26 +02:00
2026-05-28 16:52:02 +01:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2026-05-28 16:52:02 +01:00
2026-06-09 11:37:26 +02:00
2025-06-09 15:09:21 +02:00
2026-06-09 11:37:26 +02:00
2025-06-09 15:09:21 +02:00
2025-10-15 10:30:34 +02:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2025-06-09 15:09:21 +02:00
2026-04-21 23:15:34 +02:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2025-08-04 17:00:54 +02:00
2026-06-09 11:37:26 +02:00
2026-05-27 22:31:11 +01:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2026-04-27 18:34:30 +02:00
2026-06-22 16:52:53 +01:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2026-05-28 16:14:58 +01:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2026-06-09 11:37:26 +02:00
2026-05-22 09:09:01 +01:00
2025-07-18 21:44:06 +01:00
2025-07-18 21:44:06 +01:00
2025-06-09 15:09:21 +02:00
2026-08-30 17:37:09 +02:00
2026-02-16 21:39:11 +01:00
2026-02-16 21:39:11 +01:00
2026-08-30 17:37:09 +02:00
2025-10-13 08:56:23 +01:00
2026-02-16 21:39:11 +01:00
2026-03-25 08:07:49 +00:00
2025-06-09 15:09:21 +02:00
2025-06-09 15:09:21 +02:00
2026-08-12 16:14:34 +02:00
2026-08-12 16:14:34 +02:00
2025-06-09 15:09:21 +02:00