diff --git a/src/components/Comment.svelte b/src/components/Comment.svelte index 7b00ab917..b65fc752d 100644 --- a/src/components/Comment.svelte +++ b/src/components/Comment.svelte @@ -221,6 +221,7 @@
@@ -321,72 +332,72 @@ {placeholder} /> {/if} {@render belowTextarea?.()} -
- {#if !hideDiscard} - - {/if} - {#if !preview} -
- {#if embedUploadError} - - - {embedUploadError} - - {:else if attachEnabled} - Drag and drop files to add them. - {/if} - - Markdown is supported. Press {utils.modifierKey()}↵ to submit. -
- {/if} -
- {#if attachEnabled || attachDisabledReason} + {#if !hideDiscard || body.trim() !== ""} +
+ {#if !hideDiscard} {/if} - - {/if} - + + +
-
+ {/if}
diff --git a/src/components/Textarea.svelte b/src/components/Textarea.svelte index 43350538e..6da075429 100644 --- a/src/components/Textarea.svelte +++ b/src/components/Textarea.svelte @@ -209,7 +209,7 @@ {#if draggingOver}
- Drop files to add them as embeds. Embeds are limited to 10Mb. + Drop files to add them as embeds. Embeds are limited to 10MB.
{/if} diff --git a/tests/e2e/repo/issue.spec.ts b/tests/e2e/repo/issue.spec.ts index cc1f101cd..821a4ccb8 100644 --- a/tests/e2e/repo/issue.spec.ts +++ b/tests/e2e/repo/issue.spec.ts @@ -41,7 +41,7 @@ test("creation of top level comments", async ({ page }) => { .fill( "It's important for us that the comment creation flow works as expected.", ); - await page.getByRole("button", { name: "icon-checkmark" }).click(); + await page.getByRole("button", { name: /^Save/ }).click(); await expect( page.getByText("Make sure that comment creation is working"), ).toBeVisible(); @@ -54,7 +54,7 @@ test("creation of top level comments", async ({ page }) => { await page .getByPlaceholder("Leave a comment") .fill("A top level comment by playwright"); - await page.getByRole("button", { name: "icon-checkmark" }).click(); + await page.getByRole("button", { name: /^Comment/ }).click(); await expect( page.getByText("A top level comment by playwright"), ).toBeVisible(); @@ -65,7 +65,7 @@ test("creation of top level comments", async ({ page }) => { .fill( "A top level comment by playwright created by replying to the issue body", ); - await page.getByRole("button", { name: "icon-checkmark Reply" }).click(); + await page.getByRole("button", { name: /^Reply/ }).click(); await expect( page.getByText( "A top level comment by playwright created by replying to the issue body", @@ -76,7 +76,7 @@ test("creation of top level comments", async ({ page }) => { await page .getByPlaceholder("Reply to comment") .fill("A reply comment by playwright replying to the first comment"); - await page.getByRole("button", { name: "icon-checkmark Reply" }).click(); + await page.getByRole("button", { name: /^Reply/ }).click(); await expect( page.getByText( "A reply comment by playwright replying to the first comment",