Fix pasted images not rendering

Pasting a single image went through save_embed_by_clipboard, which
stored the clipboard's raw RGBA pixels instead of an encoded image.
The result could not be decoded, so the embed showed as a broken image.
Always store the pasted file's own bytes instead. Nothing else uses
save_embed_by_clipboard, so it's removed.

Co-Authored-By: Rūdolfs Ošiņš <rudolfs@osins.org>

crates/radicle-tauri/src/commands/cob.rs

@@ -5,7 +5,6 @@ use radicle::identity;
 use radicle_types as types;
 use radicle_types::error::Error;
 use radicle_types::traits::thread::Thread;
-use tauri_plugin_clipboard_manager::ClipboardExt;
 use tauri_plugin_dialog::DialogExt;
 
 use crate::AppState;
@@ -33,21 +32,6 @@ pub async fn save_embed_by_path(
     ctx.save_embed_by_path(rid, path)
 }
 
-#[tauri::command]
-pub async fn save_embed_by_clipboard(
-    app_handle: tauri::AppHandle,
-    ctx: tauri::State<'_, AppState>,
-    rid: identity::RepoId,
-    name: String,
-) -> Result<git::Oid, Error> {
-    let content = app_handle
-        .clipboard()
-        .read_image()
-        .map(|i| i.rgba().to_vec())?;
-
-    ctx.save_embed_by_bytes(rid, name, content)
-}
-
 #[tauri::command]
 pub async fn save_embed_by_bytes(
     ctx: tauri::State<'_, AppState>,

crates/radicle-tauri/src/lib.rs

@@ -88,7 +88,6 @@ pub fn run() {
             cob::patch::rebuild_patch_cache,
             cob::patch::revisions_by_patch,
             cob::save_embed_by_bytes,
-            cob::save_embed_by_clipboard,
             cob::save_embed_by_path,
             cob::save_embed_to_disk,
             diff::get_diff,

crates/radicle-types/Cargo.toml

@@ -23,7 +23,6 @@ serde_json = { version = "1.0.0" }
 sqlite = { version = "0.37.0", features = ["bundled"] }
 ssh-key = { version = "0.6.3" }
 tauri = { version = "2.11.1", features = ["isolation"] }
-tauri-plugin-clipboard-manager = { version = "2.3.2" }
 tauri-plugin-fs = { version = "2.5.0" }
 tempfile = { version = "3.19.0" }
 thiserror = { version = "2.0.12" }

crates/radicle-types/src/error.rs

@@ -54,10 +54,6 @@ pub enum Error {
     #[error(transparent)]
     AliasError(#[from] radicle::node::AliasError),
 
-    /// Tauri Plugin Clipboard error.
-    #[error(transparent)]
-    TauriPluginClipboard(#[from] tauri_plugin_clipboard_manager::Error),
-
     /// Tauri Plugin Fs error.
     #[error(transparent)]
     TauriPluginFs(#[from] tauri_plugin_fs::Error),

crates/test-http-api/tests/parity.rs

@@ -6,10 +6,7 @@ use std::fs;
 use std::path::{Path, PathBuf};
 
 /// Tauri commands with no HTTP route, and why.
-const TAURI_ONLY: &[(&str, &str)] = &[(
-    "save_embed_by_clipboard",
-    "reads the native clipboard, which the HTTP server has no access to",
-)];
+const TAURI_ONLY: &[(&str, &str)] = &[];
 
 /// HTTP routes with no Tauri command, and why.
 const HTTP_ONLY: &[(&str, &str)] = &[(