Commit Graph
20 Commits
Author SHA1 Message Date
Thomas Scholtes ef7736a8b0 Re-enable replying to review comments again 2025-07-29 14:55:02 +02:00
Rūdolfs Ošiņš 4fd016de9e Fix copyable Id reactivity
The component would always copy the first value it was initialized with
regardless of what the actual ID was that it was showing.
2025-07-22 10:09:53 +02:00
Thomas Scholtes ea395ee884 Add button to delete draft reviews 2025-07-17 11:35:13 +02:00
Thomas Scholtes ceca51c1bb Support deleting draft review comments 2025-07-17 10:48:35 +02:00
Thomas Scholtes a33799d62a Simplify reactOnComment action 2025-07-16 12:58:03 +02:00
Sebastian Martinez 2f801b9940 Add eslint-plugin-simple-import-sort to sort and group imports 2025-07-03 15:46:18 +02:00
Rūdolfs Ošiņš a55a138a7f Improve code review usability
This patch moves the revision list from the tab bar drop-down to a sidebar
on wide screens and above the current revision on narrow screens. This
way all revisions are visible at all times.

We also move and nest the revision reviews into that list so that one
can see whether there's anything actionable at a glance.

Other tweaks:

  - added comment counts to revisions and reviews
  - displayed unresolved comment thread counts per review
  - swapped icons for accepted/rejected and neutral reviews to avoid clashing
    with resolved/unresolved comment icons
  - made label and assignee sections more compact with hover-triggered "+" buttons
  - added author and status sections to the sidebar
  - enabled patch state changes from the title bar
  - made "Review revision" the primary action and "Checkout patch" secondary
  - added "Draft" label to draft patches
  - capitalized all badges for consistent UI text
2025-07-03 11:46:39 +02:00
Sebastian Martinez 18f5aa9065 Allow verdict and summary changes in draft reviews
While a patch review is still in draft mode we should allow it to be
changed to no verdict or an empty summary.

The validation logic being taken care of by the `Publish draft` button.
2025-07-02 13:54:14 +02:00
Thomas Scholtes 17586953bb Draft reviews before publishing
Reviews are locally persisted but only published to the network by an
explicit user action.

- [ ] Delete line comments on draft reviews

[squash] Sort imports, separate type imports into own section
2025-07-01 14:31:55 +02:00
Thomas Scholtes 049b2b15df Allow disabling of attachments in comments with reason
[squash] Use shorthand property
2025-07-01 14:31:55 +02:00
Rūdolfs Ošiņš 9ec894cb88 Disable attachments for reviews
They're not yet supported on a protocol level.
2025-04-04 15:20:28 +02:00
Rūdolfs Ošiņš f777284af2 Make all elements of title row same height
This is so that text areas and buttons align perfectly.
2025-04-04 10:26:54 +02:00
Rūdolfs Ošiņš 7b28e4202f Implement resolving and unresolving comments 2025-03-18 18:55:06 -06:00
Rūdolfs Ošiņš 0c1b441ed2 Show commit list in review view 2025-03-17 21:49:11 -06:00
Rūdolfs Ošiņš 2274a9c79b Refactor patch loading 2025-03-17 21:49:11 -06:00
Rūdolfs Ošiņš 87a455d2a4 Implement code comments for single line selections 2025-03-17 21:17:25 -06:00
Rūdolfs Ošiņš a28aa0d6ab Add Changes section to Review 2025-03-14 16:45:05 -06:00
Rūdolfs Ošiņš 5e6fd19a6d Add discussion section to reviews 2025-02-19 15:25:50 -06:00
Rūdolfs Ošiņš 15bb0353d0 Refactor VerdictButton props 2025-02-18 15:34:19 -06:00
Rūdolfs Ošiņš 4add00d682 Add review page 2025-02-18 12:06:03 -06:00