From 01d4c0c5b7ca76d6104a67fd21e558ae3f4e74c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Thu, 8 May 2025 11:17:36 +0200 Subject: [PATCH] Fix wrong inbox notification counters Avoid counting grouped notifications separately and omit notifications for deleted objects. --- crates/radicle-types/src/outbound/sqlite.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/radicle-types/src/outbound/sqlite.rs b/crates/radicle-types/src/outbound/sqlite.rs index f7f005daf..0a4d4cd27 100644 --- a/crates/radicle-types/src/outbound/sqlite.rs +++ b/crates/radicle-types/src/outbound/sqlite.rs @@ -118,9 +118,9 @@ impl InboxStorage for Sqlite { notification::ListNotificationsError, > { let stmt = self.db.prepare( - "SELECT ref, repo, COUNT(*) as count + "SELECT COUNT(DISTINCT substr(ref, 66)) count, ref, repo FROM `repository-notifications` - WHERE ref LIKE '%cobs%' + WHERE new NOT NULL AND (ref LIKE '%cobs/xyz.radicle.patch%' OR ref LIKE '%cobs/xyz.radicle.issue%') GROUP BY repo", )?;