From 063cdf097b5cf16aa6f1762b96c59668f9ce3169 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Fri, 17 Jan 2025 17:08:56 -0600 Subject: [PATCH] Add patch reviews --- src/components/Revision.svelte | 67 +++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/src/components/Revision.svelte b/src/components/Revision.svelte index bf8e08667..8fad0edad 100644 --- a/src/components/Revision.svelte +++ b/src/components/Revision.svelte @@ -13,13 +13,21 @@ import { announce } from "@app/components/AnnounceSwitch.svelte"; import { invoke } from "@app/lib/invoke"; import { nodeRunning } from "@app/lib/events"; - import { publicKeyFromDid, scrollIntoView } from "@app/lib/utils"; + import { + absoluteTimestamp, + authorForNodeId, + formatTimestamp, + publicKeyFromDid, + scrollIntoView, + } from "@app/lib/utils"; import Changeset from "@app/components/Changeset.svelte"; import CommentComponent from "@app/components/Comment.svelte"; import CommentToggleInput from "@app/components/CommentToggleInput.svelte"; import Icon from "@app/components/Icon.svelte"; + import NodeId from "@app/components/NodeId.svelte"; import ThreadComponent from "@app/components/Thread.svelte"; + import Markdown from "./Markdown.svelte"; interface Props { rid: string; @@ -38,6 +46,7 @@ let focusReply: boolean = $state(false); let hideChanges = $state(false); let hideDiscussion = $state(false); + let hideReviews = $state(false); let topLevelReplyOpen = $state(false); const threads = $derived( @@ -64,6 +73,7 @@ // eslint-disable-next-line @typescript-eslint/no-unused-expressions patchId; + hideReviews = false; hideDiscussion = false; hideChanges = false; }); @@ -250,6 +260,14 @@ margin-left: 1.25rem; background-color: var(--color-background-float); } + .review { + clip-path: var(--2px-corner-fill); + padding: 0.5rem 0.75rem; + font-size: var(--font-size-small); + display: flex; + flex-direction: column; + gap: 0.5rem; + }
@@ -318,6 +336,53 @@
+{#if revision.reviews && revision.reviews.length} +
+ +
(hideReviews = !hideReviews)}> + Reviews +
+
+ {#each revision.reviews as review} +
+
+ + {review.verdict === "accept" ? "accepted" : "rejected"} revision +
+ {formatTimestamp(review.timestamp)} +
+ {#if review.comments.length > 0} +
+ {review.comments.length} +
+ {/if} +
+
+ {#if review.summary?.trim()} + + {:else} + No summary. + {/if} +
+
+ {/each} +
+
+{/if} +