From 0c1b441ed260ae70fe442cfa4f9fb0ab4025be69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Mon, 17 Mar 2025 16:27:43 -0600 Subject: [PATCH] Show commit list in review view --- src/components/Changes.svelte | 63 +++++++++++++++-------------------- src/components/Review.svelte | 1 - 2 files changed, 27 insertions(+), 37 deletions(-) diff --git a/src/components/Changes.svelte b/src/components/Changes.svelte index d216f49ba..066995d9a 100644 --- a/src/components/Changes.svelte +++ b/src/components/Changes.svelte @@ -17,17 +17,10 @@ patchId: string; revision: Revision; rid: string; - showCommits?: boolean; codeComments?: CodeComments; } - const { - patchId, - revision, - rid, - showCommits = true, - codeComments, - }: Props = $props(); + const { patchId, revision, rid, codeComments }: Props = $props(); let hideChanges = $state(false); let filesExpanded = $state(true); @@ -118,35 +111,33 @@
- {#if showCommits} - {#await loadCommits(rid, revision.base, revision.head) then commits} -
- - {#snippet leftHeader()} -
Commits
- {/snippet} - {#snippet children()} -
-
- -
base
-
-
- {#each commits.reverse() as commit} -
-
- -
- {/each} -
+ {#await loadCommits(rid, revision.base, revision.head) then commits} +
+ + {#snippet leftHeader()} +
Commits
+ {/snippet} + {#snippet children()} +
+
+ +
base
- {/snippet} - -
- {/await} - {/if} +
+ {#each commits.reverse() as commit} +
+
+ +
+ {/each} +
+
+ {/snippet} + +
+ {/await} {#await loadHighlightedDiff(rid, revision.base, revision.head)} Loading… diff --git a/src/components/Review.svelte b/src/components/Review.svelte index ac8bdddeb..394ff38f5 100644 --- a/src/components/Review.svelte +++ b/src/components/Review.svelte @@ -387,7 +387,6 @@ threads: codeCommentThreads, }} rid={repo.rid} - showCommits={false} {patchId} {revision} />