Drop files only into the textarea under the cursor

This commit is contained in:
Rūdolfs Ošiņš
2026-10-06 14:44:28 +02:00
parent d6145300c1
commit 118abffdea
6 changed files with 255 additions and 42 deletions
+88
View File
@@ -0,0 +1,88 @@
import type { JSHandle, Locator, Page } from "@playwright/test";
import type { RadiclePeer } from "@tests/support/peerManager.js";
import { createProject } from "@tests/support/collaboration.js";
import { expect, test, waitForCommand } from "@tests/support/fixtures.js";
async function openIssue(page: Page, peer: RadiclePeer) {
const { rid, issueId } = await createProject(peer);
await page.goto(`/repos/${rid}/issues/${issueId}`);
await expect(page.getByText("Nobody reads them.")).toBeVisible();
}
function fileTransfer(
page: Page,
name: string,
): Promise<JSHandle<DataTransfer>> {
return page.evaluateHandle(name => {
const dataTransfer = new DataTransfer();
dataTransfer.items.add(new File(["loud"], name, { type: "text/plain" }));
return dataTransfer;
}, name);
}
async function dropFile(target: Locator, dataTransfer: JSHandle<DataTransfer>) {
for (const type of ["dragenter", "dragover", "drop"]) {
await target.dispatchEvent(type, { dataTransfer });
}
}
test("a dropped file only goes into the textarea under it", async ({
page,
peer,
}) => {
await openIssue(page, peer);
await page.getByText("Nobody reads them.").hover();
await page.getByTitle("Edit description").click();
const description = page.getByPlaceholder("Leave your comment");
await expect(description).toHaveValue("Nobody reads them.");
const composer = page.getByPlaceholder("Leave a comment");
await waitForCommand(page, "save_embed_by_bytes", () =>
fileTransfer(page, "notes.txt").then(transfer =>
dropFile(composer, transfer),
),
);
await expect(composer).toHaveValue(/\[notes\.txt\]\(\w+\)/);
await expect(description).toHaveValue("Nobody reads them.");
});
test("a file dropped while previewing is refused", async ({ page, peer }) => {
await openIssue(page, peer);
let uploads = 0;
page.on("request", request => {
if (new URL(request.url()).pathname === "/save_embed_by_bytes") {
uploads++;
}
});
await page.getByPlaceholder("Leave a comment").fill("Draft");
const composer = page.getByLabel("extended-textarea");
await composer.getByRole("button", { name: "Preview" }).click();
await dropFile(composer, await fileTransfer(page, "notes.txt"));
await composer.getByRole("button", { name: "Edit" }).click();
await expect(page.getByPlaceholder("Leave a comment")).toHaveValue("Draft");
expect(uploads).toBe(0);
});
test("the drop highlight clears once the file leaves", async ({
page,
peer,
}) => {
await openIssue(page, peer);
const transfer = await fileTransfer(page, "notes.txt");
const composer = page.getByPlaceholder("Leave a comment");
const highlight = page.getByText("Drop files to add them as embeds.");
await composer.dispatchEvent("dragenter", { dataTransfer: transfer });
await expect(highlight).toBeVisible();
// The highlight covers the textarea, so it is entered before that is left.
await highlight.dispatchEvent("dragenter", { dataTransfer: transfer });
await composer.dispatchEvent("dragleave", { dataTransfer: transfer });
await expect(highlight).toBeVisible();
await highlight.dispatchEvent("dragleave", { dataTransfer: transfer });
await expect(highlight).toBeHidden();
});
+77
View File
@@ -0,0 +1,77 @@
import { beforeAll, describe, expect, test } from "vitest";
import { disableDropNavigation } from "@app/lib/disableDropNavigation";
// happy-dom's DragEvent ignores `dataTransfer`, so it is attached by hand.
function drag(type: "dragover" | "drop", target: Element, types: string[]) {
const dataTransfer = { types, dropEffect: "copy" };
const event = new DragEvent(type, { bubbles: true, cancelable: true });
Object.defineProperty(event, "dataTransfer", { value: dataTransfer });
target.dispatchEvent(event);
return {
prevented: event.defaultPrevented,
dropEffect: dataTransfer.dropEffect,
};
}
function element(html: string): Element {
const template = document.createElement("template");
template.innerHTML = html;
const node = template.content.firstElementChild as Element;
document.body.append(node);
return node;
}
beforeAll(() => {
disableDropNavigation();
});
describe("disableDropNavigation", () => {
test.each([
["a link", ["text/uri-list", "text/plain"]],
["a file", ["Files"]],
])("refuses %s dropped on the page", (_, types) => {
const page = element("<div>page</div>");
expect(drag("dragover", page, types)).toEqual({
prevented: true,
dropEffect: "none",
});
expect(drag("drop", page, types).prevented).toBe(true);
});
test.each([
["a textarea", "<textarea></textarea>"],
["an input", "<input>"],
["an editable element", '<div contenteditable="true">x</div>'],
])("leaves text dropped into %s to the webview", (_, html) => {
const field = element(html);
const types = ["text/plain"];
expect(drag("dragover", field, types)).toEqual({
prevented: false,
dropEffect: "copy",
});
expect(drag("drop", field, types).prevented).toBe(false);
});
test("refuses text dropped on an element that isn't editable", () => {
const field = element('<div contenteditable="false">x</div>');
expect(drag("drop", field, ["text/plain"]).prevented).toBe(true);
});
test("refuses a file over a field that didn't accept it", () => {
const field = element("<textarea></textarea>");
expect(drag("dragover", field, ["Files"])).toEqual({
prevented: true,
dropEffect: "none",
});
});
test("keeps the drop effect of a field that accepted the file", () => {
const field = element("<div></div>");
field.addEventListener("dragover", event => event.preventDefault());
expect(drag("dragover", field, ["Files"])).toEqual({
prevented: true,
dropEffect: "copy",
});
});
});