From 34b2f569c1a97df5e9be5cfa2402327222224b86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Wed, 16 Aug 2023 16:53:14 +0200 Subject: [PATCH] Improve node error handling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rūdolfs Ošiņš --- src/views/nodes/router.ts | 16 ++++++++++------ tests/e2e/project.spec.ts | 1 - 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/views/nodes/router.ts b/src/views/nodes/router.ts index f5a14be3d..92f2267b6 100644 --- a/src/views/nodes/router.ts +++ b/src/views/nodes/router.ts @@ -109,11 +109,15 @@ export async function loadNodeRoute( }, }; } catch (error: any) { - return { - resource: "notFound", - params: { - title: "Node not found", - }, - }; + if (error.message === "Failed to fetch") { + return { + resource: "notFound", + params: { + title: "Node not found", + }, + }; + } else { + throw error; + } } } diff --git a/tests/e2e/project.spec.ts b/tests/e2e/project.spec.ts index 55847212f..b1ecb1adb 100644 --- a/tests/e2e/project.spec.ts +++ b/tests/e2e/project.spec.ts @@ -447,7 +447,6 @@ test("external markdown link", async ({ page }) => { }); await page.goto(`${markdownUrl}/tree/main/footnotes.md`); await page.getByRole("link", { name: "https://example.com" }).click(); - await page.pause(); await expect(page).toHaveURL("https://example.com"); });