From 41168db8d56c89c4ae231bbaeb0b0997be5bcc1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Fri, 16 Dec 2022 16:07:49 +0100 Subject: [PATCH] Improve CI workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - bump visual spec timeouts - don't warn if there are no artifacts - revert unneeded workflow checks - improve workflow messages Signed-off-by: Rūdolfs Ošiņš --- .github/workflows/check-build.yml | 5 +++-- .github/workflows/check-e2e.yml | 9 +++++---- .github/workflows/check-format.yml | 1 - .github/workflows/check-unit-test.yml | 1 - .github/workflows/check.yml | 1 - playwright.config.ts | 3 ++- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 6605f6c3b..0fc805c05 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -9,7 +9,6 @@ on: jobs: check-build: - if: github.event.pull_request.merged == false timeout-minutes: 30 runs-on: ubuntu-latest steps: @@ -25,10 +24,12 @@ jobs: run: npm run build - name: Run Playwright build smoke test run: npm run test:e2e -- --project chromium --config playwright.buildSmoke.config.ts - - uses: actions/upload-artifact@v3 + - name: Upload artifacts + uses: actions/upload-artifact@v3 if: always() with: name: test-artifacts-${{ runner.os }} retention-days: 30 + if-no-files-found: "ignore" path: | tests/artifacts/**/* diff --git a/.github/workflows/check-e2e.yml b/.github/workflows/check-e2e.yml index 47c70c3bb..98cf00a66 100644 --- a/.github/workflows/check-e2e.yml +++ b/.github/workflows/check-e2e.yml @@ -9,7 +9,6 @@ on: jobs: check-e2e: - if: github.event.pull_request.merged == false continue-on-error: true strategy: matrix: @@ -33,14 +32,14 @@ jobs: path: ~/.cache/ms-playwright key: ${{ runner.os }}-playwright-${{ hashFiles('package-lock.json') }} - - name: Cache snapshots (generate on master, load on pull_request) + - name: Cache Playwright visual snapshots uses: actions/cache@v3 id: playwright-snapshot-cache with: path: tests/visual/snapshots/**/* key: ${{ runner.os }}-snapshots - - name: Install Playwright with deps unless cached + - name: Install Playwright browsers and OS dependencies if cache miss if: steps.playwright-dep-cache.outputs.cache-hit != 'true' run: npx playwright install --with-deps @@ -59,10 +58,12 @@ jobs: npm run test:e2e -- --project ${{ matrix.browser }}; fi - - uses: actions/upload-artifact@v3 + - name: Upload artifacts + uses: actions/upload-artifact@v3 if: always() with: name: test-artifacts-${{ runner.os }} retention-days: 30 + if-no-files-found: "ignore" path: | tests/artifacts/**/* diff --git a/.github/workflows/check-format.yml b/.github/workflows/check-format.yml index bab23a051..a39213889 100644 --- a/.github/workflows/check-format.yml +++ b/.github/workflows/check-format.yml @@ -9,7 +9,6 @@ on: jobs: check-format: - if: github.event.pull_request.merged == false runs-on: ubuntu-latest steps: - name: Setup Node diff --git a/.github/workflows/check-unit-test.yml b/.github/workflows/check-unit-test.yml index 154e707b4..0032bde8a 100644 --- a/.github/workflows/check-unit-test.yml +++ b/.github/workflows/check-unit-test.yml @@ -9,7 +9,6 @@ on: jobs: check-unit-test: - if: github.event.pull_request.merged == false runs-on: ubuntu-latest steps: - name: Setup Node diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 4d36f7d25..c2d60037e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -9,7 +9,6 @@ on: jobs: check: - if: github.event.pull_request.merged == false runs-on: ubuntu-latest steps: - name: Setup Node diff --git a/playwright.config.ts b/playwright.config.ts index 6eb04fcc9..b51284ff5 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -41,8 +41,9 @@ const config: PlaywrightTestConfig = { }, { name: "visual", + timeout: 60_000, expect: { - timeout: 16_000, + timeout: 30_000, toHaveScreenshot: { threshold: 0.1, scale: "device",