From 472993c6dfc0790a751c9fbba7d5145f2cd8fb2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= <rudolfs@osins.org>
Date: Wed, 17 Jul 2024 14:13:57 +0200
Subject: [PATCH] Simplify share button link resolution

We just use the radicleExplorer that is configured in the app config and
don't query the node for it. Besides simplifying things this also makes
the button work on iOS again, because we don't have the async http
request anymore.
---
 src/views/projects/Commit.svelte              |  2 +-
 src/views/projects/Issue.svelte               |  2 +-
 src/views/projects/Issues.svelte              |  2 +-
 src/views/projects/Patch.svelte               |  2 +-
 src/views/projects/Patches.svelte             |  2 +-
 src/views/projects/Share.svelte               | 36 ++++---------------
 .../projects/Source/ProjectNameHeader.svelte  |  2 +-
 7 files changed, 12 insertions(+), 36 deletions(-)

diff --git a/src/views/projects/Commit.svelte b/src/views/projects/Commit.svelte
index d58a859d6..b3fdc7ad5 100644
--- a/src/views/projects/Commit.svelte
+++ b/src/views/projects/Commit.svelte
@@ -64,7 +64,7 @@
                 <IconSmall name="chevron-left-right" />
               </Button>
             </Link>
-            <Share {baseUrl} />
+            <Share />
           </div>
         </span>
         <CommitAuthorship {header}>
diff --git a/src/views/projects/Issue.svelte b/src/views/projects/Issue.svelte
index 0783dea70..173793556 100644
--- a/src/views/projects/Issue.svelte
+++ b/src/views/projects/Issue.svelte
@@ -136,7 +136,7 @@
               <span class="txt-missing">No title</span>
             {/if}
           </div>
-          <Share {baseUrl} />
+          <Share />
         </svelte:fragment>
         <svelte:fragment slot="state">
           {#if issue.state.status === "open"}
diff --git a/src/views/projects/Issues.svelte b/src/views/projects/Issues.svelte
index d52dbcaad..8f7b0e2c6 100644
--- a/src/views/projects/Issues.svelte
+++ b/src/views/projects/Issues.svelte
@@ -167,7 +167,7 @@
       </DropdownList>
     </Popover>
 
-    <Share {baseUrl} />
+    <Share />
   </div>
 
   <List items={allIssues}>
diff --git a/src/views/projects/Patch.svelte b/src/views/projects/Patch.svelte
index 5f773d144..b9b537f6f 100644
--- a/src/views/projects/Patch.svelte
+++ b/src/views/projects/Patch.svelte
@@ -304,7 +304,7 @@
           {:else}
             <span class="txt-missing">No title</span>
           {/if}
-          <Share {baseUrl} />
+          <Share />
         </svelte:fragment>
         <svelte:fragment slot="state">
           <Badge size="tiny" variant={badgeColor(patch.state.status)}>
diff --git a/src/views/projects/Patches.svelte b/src/views/projects/Patches.svelte
index 06617b8eb..c03556b19 100644
--- a/src/views/projects/Patches.svelte
+++ b/src/views/projects/Patches.svelte
@@ -174,7 +174,7 @@
       </DropdownList>
     </Popover>
 
-    <Share {baseUrl} />
+    <Share />
   </div>
 
   <List items={allPatches}>
diff --git a/src/views/projects/Share.svelte b/src/views/projects/Share.svelte
index 8ad0a8e9a..17165c561 100644
--- a/src/views/projects/Share.svelte
+++ b/src/views/projects/Share.svelte
@@ -1,52 +1,28 @@
 <script lang="ts">
-  import type { BaseUrl } from "@http-client";
-
   import config from "virtual:config";
   import debounce from "lodash/debounce";
-  import { HttpdClient } from "@http-client";
   import { toClipboard } from "@app/lib/utils";
 
   import Button from "@app/components/Button.svelte";
   import IconSmall from "@app/components/IconSmall.svelte";
 
-  export let baseUrl: BaseUrl;
-
   let shareIcon: "link" | "checkmark" = "link";
-  let loading = false;
 
   const restoreIcon = debounce(() => {
     shareIcon = "link";
   }, 1000);
 
-  $: api = new HttpdClient(baseUrl);
-
   async function copy() {
-    if (loading) {
-      return;
-    }
-    try {
-      loading = true;
-      const profile = await api.profile.getProfile().catch(() => undefined);
-      const publicExplorer =
-        profile?.config.publicExplorer ?? config.nodes.fallbackPublicExplorer;
-      const text = new URL(publicExplorer).origin.concat(
-        window.location.pathname,
-      );
-      await toClipboard(text);
-      shareIcon = "checkmark";
-    } finally {
-      loading = false;
-    }
+    const text = new URL(config.nodes.fallbackPublicExplorer).origin.concat(
+      window.location.pathname,
+    );
+    await toClipboard(text);
+    shareIcon = "checkmark";
     restoreIcon();
   }
 </script>
 
-<Button
-  variant="outline"
-  size="regular"
-  on:click={async () => {
-    await copy();
-  }}>
+<Button variant="outline" size="regular" on:click={copy}>
   <IconSmall name={shareIcon} />
   <span class="global-hide-on-small-desktop-down">Copy link</span>
 </Button>
diff --git a/src/views/projects/Source/ProjectNameHeader.svelte b/src/views/projects/Source/ProjectNameHeader.svelte
index 360fe03dc..ef3dc2dde 100644
--- a/src/views/projects/Source/ProjectNameHeader.svelte
+++ b/src/views/projects/Source/ProjectNameHeader.svelte
@@ -82,7 +82,7 @@
       </Badge>
     {/if}
     <div style="margin-left: auto; display: flex; gap: 0.5rem;">
-      <Share {baseUrl} />
+      <Share />
       <div
         style:display="flex"
         style:gap="0.5rem"