diff --git a/public/index.css b/public/index.css index be8155414..371c14514 100644 --- a/public/index.css +++ b/public/index.css @@ -111,6 +111,30 @@ body { 0 calc(100% - 2px) ); + --1px-top-corner-fill: polygon( + 0 2px, + 2px 2px, + 2px 0, + calc(100% - 2px) 0, + calc(100% - 2px) 2px, + 100% 2px, + 100% calc(100% - 2px), + 100% 4px, + 100% 100%, + 0 100% + ); + + --1px-bottom-corner-fill: polygon( + 0 0, + 100% 0, + 100% calc(100% - 2px), + calc(100% - 2px) calc(100% - 2px), + calc(100% - 2px) 100%, + 2px 100%, + 2px calc(100% - 2px), + 0 calc(100% - 2px) + ); + --2px-corner-fill: polygon( 0 4px, 2px 4px, diff --git a/src/components/IssueSecondColumn.svelte b/src/components/IssueSecondColumn.svelte index 1fdacafa5..8d22aa386 100644 --- a/src/components/IssueSecondColumn.svelte +++ b/src/components/IssueSecondColumn.svelte @@ -71,13 +71,7 @@ display: flex; align-items: center; min-height: 2.5rem; - } - .issue-list { - margin-top: 1rem; - display: flex; - flex-direction: column; - gap: 2px; - padding-bottom: 1rem; + margin-bottom: 1rem; } @@ -218,10 +212,17 @@ {/if} -
+ {#each searchResults as result} -
-
- - {#if issues.length > 0 && searchResults.length === 0} - No matching issues. - {:else} - No {status === "all" ? "" : status} issues. - {/if} -
+
+
+ + {#if issues.length > 0 && searchResults.length === 0} + No matching issues. + {:else} + No {status === "all" ? "" : status} issues. + {/if}
- +
{/if} -
+
diff --git a/src/components/IssueTeaser.svelte b/src/components/IssueTeaser.svelte index c02b51edc..9c0c484c8 100644 --- a/src/components/IssueTeaser.svelte +++ b/src/components/IssueTeaser.svelte @@ -42,6 +42,7 @@ align-items: center; gap: 0.25rem; min-height: 5rem; + min-width: 405px; background-color: var(--color-background-float); padding: 1rem; cursor: pointer; @@ -60,13 +61,13 @@ margin-right: 1rem; } .issue-teaser:first-of-type { - clip-path: var(--3px-top-corner-fill); + clip-path: var(--1px-top-corner-fill); } .issue-teaser:last-of-type { - clip-path: var(--3px-bottom-corner-fill); + clip-path: var(--1px-bottom-corner-fill); } .issue-teaser:only-of-type { - clip-path: var(--3px-corner-fill); + clip-path: var(--1px-corner-fill); } diff --git a/src/components/PatchTeaser.svelte b/src/components/PatchTeaser.svelte index d32ea7d60..28e146d89 100644 --- a/src/components/PatchTeaser.svelte +++ b/src/components/PatchTeaser.svelte @@ -47,6 +47,7 @@ justify-content: space-between; gap: 0.25rem; min-height: 5rem; + min-width: 440px; background-color: var(--color-background-float); padding: 1rem; cursor: pointer; @@ -65,13 +66,13 @@ margin-right: 1rem; } .patch-teaser:first-of-type { - clip-path: var(--3px-top-corner-fill); + clip-path: var(--1px-top-corner-fill); } .patch-teaser:last-of-type { - clip-path: var(--3px-bottom-corner-fill); + clip-path: var(--1px-bottom-corner-fill); } .patch-teaser:only-of-type { - clip-path: var(--3px-corner-fill); + clip-path: var(--1px-corner-fill); } diff --git a/src/views/repo/Issues.svelte b/src/views/repo/Issues.svelte index cc82ac708..1c6e69df4 100644 --- a/src/views/repo/Issues.svelte +++ b/src/views/repo/Issues.svelte @@ -62,11 +62,6 @@ .container { padding: 1rem 1rem 1rem 0; } - .list { - display: flex; - flex-direction: column; - gap: 2px; - } .header { font-weight: var(--font-weight-medium); font-size: var(--font-size-medium); @@ -141,35 +136,34 @@
-
+ {#each searchResults as result} - + {/each} {#if searchResults.length === 0} - -
-
- - {#if issues.length > 0 && searchResults.length === 0} - No matching issues. - {:else} - No {status === "all" ? "" : status} issues. - {/if} -
+
+
+ + {#if issues.length > 0 && searchResults.length === 0} + No matching issues. + {:else} + No {status === "all" ? "" : status} issues. + {/if}
- +
{/if} -
+
diff --git a/src/views/repo/Patch.svelte b/src/views/repo/Patch.svelte index 6a620c8b8..f9c3d8e02 100644 --- a/src/views/repo/Patch.svelte +++ b/src/views/repo/Patch.svelte @@ -325,13 +325,6 @@ height: 2.5rem; width: 2.5rem; } - .patch-list { - margin-top: 1rem; - display: flex; - flex-direction: column; - gap: 2px; - padding-bottom: 1rem; - } .content { padding: 1rem 1rem 1rem 0; } @@ -389,7 +382,10 @@ {/snippet} {#snippet secondColumn()} -
+
{project.data.name} @@ -502,10 +498,17 @@ {/if}
{/if} -
+ {#each searchResults as teaser} { review = undefined; @@ -518,27 +521,22 @@ {/each} {#if searchResults.length === 0} - -
-
- - {#if patchTeasers.length > 0 && searchResults.length === 0} - No matching patches. - {:else} - No {status === undefined ? "" : status} patches. - {/if} -
+
+
+ + {#if patchTeasers.length > 0 && searchResults.length === 0} + No matching patches. + {:else} + No {status === undefined ? "" : status} patches. + {/if}
- +
{/if} -
+
{/snippet} {#if review} diff --git a/src/views/repo/Patches.svelte b/src/views/repo/Patches.svelte index 8c02af81d..e045c4de1 100644 --- a/src/views/repo/Patches.svelte +++ b/src/views/repo/Patches.svelte @@ -174,19 +174,20 @@
- {#each searchResults as result} - - {/each} + + {#each searchResults as result} + + {/each} - {#if searchResults.length === 0} - + {#if searchResults.length === 0}
-
- {/if} + {/if} +
diff --git a/tests/e2e/repo/issue.spec.ts b/tests/e2e/repo/issue.spec.ts index fa4c587d9..48d2aea42 100644 --- a/tests/e2e/repo/issue.spec.ts +++ b/tests/e2e/repo/issue.spec.ts @@ -10,9 +10,7 @@ test("navigate single issue", async ({ page }) => { test("correct order of threads", async ({ page }) => { await page.goto("/repos"); await page.getByRole("button", { name: "cobs" }).click(); - await page - .getByRole("button", { name: "This title has **markdown**" }) - .click(); + await page.getByText("This title has **markdown**").click(); const body = page.locator(".issue-body"); await expect(body.getByText("This is a description")).toBeVisible(); @@ -43,10 +41,10 @@ test("creation of top level comments", async ({ page }) => { ); await page.getByRole("button", { name: "icon-checkmark" }).click(); await expect( - page.getByText("Make sure that comment creation is working").last(), - ).toBeVisible(); - await expect( - page.getByRole("button", { name: "icon-issue Make sure that" }), + page.getByRole("button", { + name: "icon-issue Make sure that comment creation is working avatar palm opened 8faf9dc 6 months ago", + exact: true, + }), ).toBeVisible(); await expect( page diff --git a/tests/e2e/repos.spec.ts b/tests/e2e/repos.spec.ts index 2cf5cfb9c..352536ce1 100644 --- a/tests/e2e/repos.spec.ts +++ b/tests/e2e/repos.spec.ts @@ -3,9 +3,7 @@ import { expect, test } from "@tests/support/fixtures.js"; test("navigate to repo issues", async ({ page }) => { await page.goto("/repos"); await page.getByRole("button", { name: "cobs" }).click(); - await page - .getByRole("button", { name: "This title has **markdown**" }) - .click(); + await page.getByText("This title has **markdown**").click(); await expect( page.getByText("This title has **markdown**").nth(1), ).toBeVisible();