diff --git a/src/components/Reviews.svelte b/src/components/Reviews.svelte new file mode 100644 index 000000000..796ff109f --- /dev/null +++ b/src/components/Reviews.svelte @@ -0,0 +1,130 @@ + + + + +
+
+ (hideReviews = !hideReviews)}> + +
+ Reviews + {revision.reviews?.length ?? 0} + +
+
+ +
+ createReview()}> + + Write Review + + + +
+
+ + {#if revision.reviews && revision.reviews.length} +
+ {#each revision.reviews as review} + + {/each} +
+ {/if} +
diff --git a/src/components/Revision.svelte b/src/components/Revision.svelte index 9bf95ad39..b1aa0add2 100644 --- a/src/components/Revision.svelte +++ b/src/components/Revision.svelte @@ -5,7 +5,6 @@ import type { PatchStatus } from "@app/views/repo/router"; import type { Revision } from "@bindings/cob/patch/Revision"; import type { Thread } from "@bindings/cob/thread/Thread"; - import type { Verdict } from "@bindings/cob/patch/Verdict"; import partial from "lodash/partial"; @@ -13,15 +12,12 @@ import { announce } from "@app/components/AnnounceSwitch.svelte"; import { invoke } from "@app/lib/invoke"; import { nodeRunning } from "@app/lib/events"; - import { didFromPublicKey, publicKeyFromDid } from "@app/lib/utils"; + import { publicKeyFromDid } from "@app/lib/utils"; - import Button from "@app/components/Button.svelte"; import Changes from "@app/components/Changes.svelte"; import CommentComponent from "@app/components/Comment.svelte"; - import Discussion from "./Discussion.svelte"; - import Icon from "@app/components/Icon.svelte"; - import NakedButton from "@app/components/NakedButton.svelte"; - import ReviewTeaser from "@app/components/ReviewTeaser.svelte"; + import Discussion from "@app/components/Discussion.svelte"; + import Reviews from "@app/components/Reviews.svelte"; interface Props { rid: string; @@ -38,27 +34,6 @@ $props(); /* eslint-enable prefer-const */ - const hasOwnReview = $derived( - Boolean( - revision.reviews && - revision.reviews.some( - value => value.author.did === didFromPublicKey(config.publicKey), - ), - ), - ); - - let hideReviews = $state( - revision.reviews === undefined || revision.reviews.length === 0, - ); - - $effect(() => { - // eslint-disable-next-line @typescript-eslint/no-unused-expressions - patchId; - - hideReviews = - revision.reviews === undefined || revision.reviews.length === 0; - }); - const commentThreads = $derived( ((revision.discussion && revision.discussion @@ -130,28 +105,6 @@ } } - async function createReview(verdict?: Verdict) { - try { - await invoke("edit_patch", { - rid: rid, - cobId: patchId, - action: { - type: "review", - revision: revision.id, - verdict, - // We need to pass an empty string to create a review without a verdict. - summary: "", - labels: [], - }, - opts: { announce: $nodeRunning && $announce }, - }); - } catch (error) { - console.error("Creating a review failed: ", error); - } finally { - await reload(); - } - } - async function createComment( body: string, embeds: Embed[], @@ -238,9 +191,6 @@ height: 100%; top: 0; } - .hide { - display: none; - }
@@ -264,56 +214,7 @@
-
-
- (hideReviews = !hideReviews)}> - -
- Reviews - {revision.reviews?.length ?? 0} - -
-
- -
- createReview()}> - - Write Review - - - -
-
- - {#if revision.reviews && revision.reviews.length} -
- {#each revision.reviews as review} - - {/each} -
- {/if} -
+