diff --git a/src/components/ReviewTeaser.svelte b/src/components/ReviewTeaser.svelte index 95e2578ec..901da4f3c 100644 --- a/src/components/ReviewTeaser.svelte +++ b/src/components/ReviewTeaser.svelte @@ -73,14 +73,17 @@ .accepted { background-color: var(--color-fill-diff-green-light); + color: var(--color-foreground-success); } .rejected { background-color: var(--color-fill-diff-red-light); + color: var(--color-foreground-red); } .no-verdict { background-color: var(--color-fill-ghost); + color: var(--color-foreground-dim); } diff --git a/src/components/VerdictBadge.svelte b/src/components/VerdictBadge.svelte index 80aa792a7..b1140f1bf 100644 --- a/src/components/VerdictBadge.svelte +++ b/src/components/VerdictBadge.svelte @@ -3,7 +3,7 @@ import type { Snippet } from "svelte"; import capitalize from "lodash/capitalize.js"; - import { verdictIcon, verdictIconColor } from "@app/lib/utils"; + import { verdictIcon } from "@app/lib/utils"; import Icon from "@app/components/Icon.svelte"; @@ -23,6 +23,7 @@ } .no-verdict { background-color: var(--color-fill-ghost); + color: var(--color-foreground-dim); } .no-verdict.hoverable:hover { background-color: var(--color-fill-ghost-hover); @@ -30,6 +31,7 @@ .accepted { background-color: var(--color-fill-diff-green-light); + color: var(--color-foreground-success); } .accepted.hoverable:hover { background-color: var(--color-fill-diff-green); @@ -37,6 +39,7 @@ .rejected { background-color: var(--color-fill-diff-red-light); + color: var(--color-foreground-red); } .rejected.hoverable:hover { background-color: var(--color-fill-diff-red); @@ -45,7 +48,6 @@ @@ -58,7 +69,11 @@ await onSelect(action); closeFocused(); }}> - + {action ? capitalize(`${action}ed`) : "None"} diff --git a/src/lib/utils.ts b/src/lib/utils.ts index 70b518af6..24f3f40fa 100644 --- a/src/lib/utils.ts +++ b/src/lib/utils.ts @@ -248,13 +248,3 @@ export function verdictIcon(verdict: Review["verdict"]) { return "comment"; } } - -export function verdictIconColor(verdict: Review["verdict"]) { - if (verdict === "accept") { - return "var(--color-foreground-success)"; - } else if (verdict === "reject") { - return "var(--color-foreground-red)"; - } else { - return "var(--color-foreground-dim)"; - } -}