diff --git a/src/lib/router.ts b/src/lib/router.ts index 0b8472fc9..11f15c456 100644 --- a/src/lib/router.ts +++ b/src/lib/router.ts @@ -87,7 +87,7 @@ async function navigateToUrl( if (route) { await navigate(action, route); } else { - console.error("Could not resolve route for URL: ", url); + console.error(`Could not resolve route for URL: ${url.href}`); await navigate(action, { resource: "inbox" }); } } diff --git a/tests/e2e/clipboard.spec.ts b/tests/e2e/clipboard.spec.ts index 26877e764..e96056ee1 100644 --- a/tests/e2e/clipboard.spec.ts +++ b/tests/e2e/clipboard.spec.ts @@ -10,7 +10,7 @@ test("copy to clipboard", async () => { await context.grantPermissions(["clipboard-read", "clipboard-write"]); const page = await context.newPage(); - await page.goto("/repos"); + await page.goto("/inbox"); // Reset system clipboard to a known state. await page.evaluate("navigator.clipboard.writeText('')"); diff --git a/tests/e2e/navigation.spec.ts b/tests/e2e/navigation.spec.ts index 79ad37508..fb0186f49 100644 --- a/tests/e2e/navigation.spec.ts +++ b/tests/e2e/navigation.spec.ts @@ -36,9 +36,6 @@ async function openIssues(page: Page) { } async function launch(page: Page) { - await page.addInitScript(() => - localStorage.setItem("appFirstLaunch", "false"), - ); await page.goto("/inbox"); await expect(page.getByRole("link", { name: "cobs" })).toBeVisible(); } diff --git a/tests/e2e/repo/issue.spec.ts b/tests/e2e/repo/issue.spec.ts index 62987677d..ee276b813 100644 --- a/tests/e2e/repo/issue.spec.ts +++ b/tests/e2e/repo/issue.spec.ts @@ -8,7 +8,7 @@ test("navigate single issue", async ({ page }) => { }); test("correct order of threads", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await page.getByRole("link", { name: "cobs" }).click(); await page.getByRole("link", { name: "Issues" }).click(); await page.getByText("This title has **markdown**").click(); @@ -29,7 +29,7 @@ test("correct order of threads", async ({ page }) => { }); test("creation of top level comments", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await page.getByRole("link", { name: "cobs" }).click(); await page.getByRole("link", { name: "Issues" }).click(); await page.getByRole("button", { name: "New" }).click(); diff --git a/tests/e2e/repos.spec.ts b/tests/e2e/repos.spec.ts index 9859db26e..9afa43507 100644 --- a/tests/e2e/repos.spec.ts +++ b/tests/e2e/repos.spec.ts @@ -1,7 +1,7 @@ import { expect, test } from "@tests/support/fixtures.js"; test("navigate to repo issues", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await page.getByRole("link", { name: "cobs" }).click(); await page.getByRole("link", { name: "Issues" }).click(); await page.getByText("This title has **markdown**").click(); diff --git a/tests/e2e/theme.spec.ts b/tests/e2e/theme.spec.ts index af14e3404..cc01c23e6 100644 --- a/tests/e2e/theme.spec.ts +++ b/tests/e2e/theme.spec.ts @@ -1,13 +1,13 @@ import { expect, reload, test } from "@tests/support/fixtures.js"; test("default theme", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await expect(page.locator("html")).toHaveAttribute("data-theme", "dark"); }); test("theme persistence", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await expect(page.getByRole("link", { name: "markdown" })).toBeVisible(); await page.getByRole("button", { name: "Settings" }).click(); @@ -20,7 +20,7 @@ test("theme persistence", async ({ page }) => { }); test("change theme", async ({ page }) => { - await page.goto("/repos"); + await page.goto("/inbox"); await expect(page.getByRole("link", { name: "markdown" })).toBeVisible(); await page.getByRole("button", { name: "Settings" }).click(); diff --git a/tests/support/fixtures.ts b/tests/support/fixtures.ts index a94c7011f..94a13cd27 100644 --- a/tests/support/fixtures.ts +++ b/tests/support/fixtures.ts @@ -34,6 +34,12 @@ export const test = base.extend<{ }>({ forAllTests: [ async ({ outputLog, page }, use) => { + // Otherwise the app opens the guide on its first launch, depending on + // how fast startup is. + await page.addInitScript(() => + localStorage.setItem("appFirstLaunch", "false"), + ); + const browserLabel = logLabel.logPrefix("browser"); page.on("console", msg => { // Ignore common console logs that we don't care about.