From 7a5fa363bedb518e2641bd020f67682197bb5999 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Fri, 7 Aug 2026 12:24:56 +0200 Subject: [PATCH] Remove unused patch read commands and diff helper `revision_by_patch_and_id` and `review_by_patch_and_revision_and_id` were registered as Tauri commands but never invoked: the patch view resolves a revision or review from the revisions it already holds. Drop the commands, their registrations and the `revision_by_id` / `review_by_id` port methods, which had no other callers. `fileDiffName` in `diffText` has had no callers since it was added. --- .../radicle-tauri/src/commands/cob/patch.rs | 23 +--------- crates/radicle-tauri/src/lib.rs | 2 - crates/radicle-types/src/traits/patch.rs | 42 ------------------- src/lib/diffText.ts | 6 --- 4 files changed, 1 insertion(+), 72 deletions(-) diff --git a/crates/radicle-tauri/src/commands/cob/patch.rs b/crates/radicle-tauri/src/commands/cob/patch.rs index 36e687563..f38ecb574 100644 --- a/crates/radicle-tauri/src/commands/cob/patch.rs +++ b/crates/radicle-tauri/src/commands/cob/patch.rs @@ -2,7 +2,7 @@ use std::ops::ControlFlow; use radicle::patch::{ReviewId, TYPENAME}; use radicle::storage::{ReadRepository as _, ReadStorage}; -use radicle::{cob, git, identity}; +use radicle::{git, identity}; use radicle_types as types; use radicle_types::cobs; @@ -53,27 +53,6 @@ pub fn revisions_by_patch( ctx.revisions_by_patch(rid, id) } -#[tauri::command] -pub fn revision_by_patch_and_id( - ctx: tauri::State, - rid: identity::RepoId, - id: git::Oid, - revision_id: git::Oid, -) -> Result, Error> { - ctx.revision_by_id(rid, id, revision_id) -} - -#[tauri::command] -pub fn review_by_patch_and_revision_and_id( - ctx: tauri::State, - rid: identity::RepoId, - id: git::Oid, - revision_id: git::Oid, - review_id: cob::patch::ReviewId, -) -> Result, Error> { - ctx.review_by_id(rid, id, revision_id, review_id) -} - #[tauri::command] pub fn edit_patch( ctx: tauri::State, diff --git a/crates/radicle-tauri/src/lib.rs b/crates/radicle-tauri/src/lib.rs index 44b6e9327..d36ad779a 100644 --- a/crates/radicle-tauri/src/lib.rs +++ b/crates/radicle-tauri/src/lib.rs @@ -49,9 +49,7 @@ pub fn run() { cob::patch::patch_by_id, cob::patch::create_patch_review, cob::patch::rebuild_patch_cache, - cob::patch::review_by_patch_and_revision_and_id, cob::patch::revisions_by_patch, - cob::patch::revision_by_patch_and_id, cob::patch::revisions_by_patch, cob::save_embed_by_bytes, cob::save_embed_by_clipboard, diff --git a/crates/radicle-types/src/traits/patch.rs b/crates/radicle-types/src/traits/patch.rs index b379170fc..b029c24ff 100644 --- a/crates/radicle-types/src/traits/patch.rs +++ b/crates/radicle-types/src/traits/patch.rs @@ -48,48 +48,6 @@ pub trait Patches: Profile { Ok::<_, Error>(revisions) } - - fn revision_by_id( - &self, - rid: identity::RepoId, - id: git::Oid, - revision_id: git::Oid, - ) -> Result, Error> { - let profile = self.profile(); - let repo = profile.storage.repository(rid)?; - let patches = profile.patches(&repo)?; - let revision = patches.get(&id.into())?.and_then(|patch| { - let aliases = &profile.aliases(); - - patch - .revision(&revision_id.into()) - .map(|r| models::patch::Revision::new(r.clone(), aliases)) - }); - - Ok::<_, Error>(revision) - } - - fn review_by_id( - &self, - rid: identity::RepoId, - id: git::Oid, - revision_id: git::Oid, - review_id: cob::patch::ReviewId, - ) -> Result, Error> { - let profile = self.profile(); - let repo = profile.storage.repository(rid)?; - let patches = profile.patches(&repo)?; - let review = patches.get(&id.into())?.and_then(|patch| { - let aliases = &profile.aliases(); - - patch - .reviews_of(revision_id.into()) - .find(|(id, _)| *id == &review_id) - .map(|(_, review)| models::patch::Review::new(review.clone(), aliases)) - }); - - Ok::<_, Error>(review) - } } pub trait PatchesMut: Profile { diff --git a/src/lib/diffText.ts b/src/lib/diffText.ts index 730cba278..7832d1f95 100644 --- a/src/lib/diffText.ts +++ b/src/lib/diffText.ts @@ -7,9 +7,3 @@ export function fileDiffPath(file: FileDiff): string { ? file.newPath : file.path; } - -// A default filename for saving a single file's diff to disk. -export function fileDiffName(file: FileDiff): string { - const base = fileDiffPath(file).split("/").pop() || "file"; - return `${base}.diff`; -}