From 94c85ad06b2fae9d0cc998d7846ff4875360f0e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= <rudolfs@osins.org>
Date: Wed, 2 Apr 2025 15:35:24 +0200
Subject: [PATCH] Fix review section toggle

This also makes all section toggles more robust against reordering of
CSS classes.
---
 src/components/Changes.svelte    | 5 +----
 src/components/Discussion.svelte | 7 +++----
 src/components/Reviews.svelte    | 5 +----
 src/views/repo/Issue.svelte      | 7 +++----
 4 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/src/components/Changes.svelte b/src/components/Changes.svelte
index 22ae70c70..7f8015efd 100644
--- a/src/components/Changes.svelte
+++ b/src/components/Changes.svelte
@@ -106,9 +106,6 @@
     background-color: var(--color-background-float);
     color: var(--color-foreground-contrast) !important;
   }
-  .hide {
-    display: none;
-  }
 </style>
 
 <div
@@ -135,7 +132,7 @@
   {/if}
 </div>
 
-<div class:hide={hideChanges}>
+<div style:display={hideChanges ? "none" : "revert"}>
   {#await cachedListCommits(rid, revision.base, revision.head) then commits}
     <div style:margin-bottom="1rem">
       <CommitsContainer>
diff --git a/src/components/Discussion.svelte b/src/components/Discussion.svelte
index 466fc9d7d..983e0b374 100644
--- a/src/components/Discussion.svelte
+++ b/src/components/Discussion.svelte
@@ -90,9 +90,6 @@
     margin-left: 1.25rem;
     background-color: var(--color-background-float);
   }
-  .hide {
-    display: none;
-  }
 </style>
 
 <div style:margin={hideDiscussion ? "1.5rem 0" : "1.5rem 0 2.5rem 0"}>
@@ -130,7 +127,9 @@
       </NakedButton>
     </div>
   </div>
-  <div class:hide={hideDiscussion} style:margin-top="1rem">
+  <div
+    style:display={hideDiscussion ? "none" : "revert"}
+    style:margin-top="1rem">
     {#each commentThreads as thread}
       <ThreadComponent
         {thread}
diff --git a/src/components/Reviews.svelte b/src/components/Reviews.svelte
index 8a9da0dc2..bea7872d2 100644
--- a/src/components/Reviews.svelte
+++ b/src/components/Reviews.svelte
@@ -71,9 +71,6 @@
 </script>
 
 <style>
-  .hide {
-    display: none;
-  }
   .review-list {
     margin-top: 1rem;
     display: flex;
@@ -125,7 +122,7 @@
   </div>
 
   {#if revision.reviews && revision.reviews.length}
-    <div class:hide={hideReviews} class="review-list">
+    <div style:display={hideReviews ? "none" : "revert"} class="review-list">
       {#each revision.reviews as review, idx}
         <ReviewTeaser
           {rid}
diff --git a/src/views/repo/Issue.svelte b/src/views/repo/Issue.svelte
index c26991fd6..28776e0b0 100644
--- a/src/views/repo/Issue.svelte
+++ b/src/views/repo/Issue.svelte
@@ -344,9 +344,6 @@
     margin-bottom: 0.5rem;
     color: var(--color-foreground-dim);
   }
-  .hide {
-    display: none;
-  }
 </style>
 
 <Layout publicKey={config.publicKey}>
@@ -521,7 +518,9 @@
         <div class="txt-semibold global-flex txt-regular">Timeline</div>
       </NakedButton>
     </div>
-    <div class:hide={hideTimeline} style:margin-top="1rem">
+    <div
+      style:display={hideTimeline ? "none" : "revert"}
+      style:margin-top="1rem">
       <IssueTimeline {activity} />
     </div>
   </div>