From 972b5ccf20e43b6f3270edb0db4760580b882018 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Fri, 6 Jan 2023 15:14:24 +0100 Subject: [PATCH] Remove playwright dependency install steps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It seems like the tests on CI work just fine without installing the deps. We assume the deps are already installed in the ubuntu image. This saves build time and our builds still work when the azure servers that provide the deps are down. Signed-off-by: Rūdolfs Ošiņš --- .github/workflows/check-build.yml | 2 +- .github/workflows/check-e2e.yml | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 0fc805c05..2fedb1f5f 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -19,7 +19,7 @@ jobs: - name: Install dependencies run: npm ci - name: Install Playwright Browsers - run: npx playwright install --with-deps + run: npx playwright install chromium - name: Build app run: npm run build - name: Run Playwright build smoke test diff --git a/.github/workflows/check-e2e.yml b/.github/workflows/check-e2e.yml index 534ed647e..222a54c2c 100644 --- a/.github/workflows/check-e2e.yml +++ b/.github/workflows/check-e2e.yml @@ -50,13 +50,9 @@ jobs: path: tests/visual/snapshots/**/* key: ${{ runner.os }}-snapshots - - name: Install Playwright browsers and OS dependencies if cache miss + - name: Install Playwright browsers if: steps.playwright-dep-cache.outputs.cache-hit != 'true' - run: npx playwright install --with-deps - - - name: Install only Playwright OS dependencies if cache hit - if: steps.playwright-dep-cache.outputs.cache-hit == 'true' - run: npx playwright install-deps + run: npx playwright install chromium firefox - name: Start http-api test server run: |