From 9ca1d7973ef5136eecdd3c005e121de5029c4008 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Wed, 22 Apr 2026 14:57:51 +0200 Subject: [PATCH] Fix GitHub actions warnings Gets rid of "Node.js 20 actions are deprecated". --- .github/workflows/check-build.yml | 9 ++++++--- .github/workflows/check-e2e.yml | 11 +++++++---- .github/workflows/check-http-client-unit-test.yml | 7 +++++-- .github/workflows/check-radicle-httpd.yml | 9 ++++++--- .github/workflows/check-unit-test.yml | 7 +++++-- .github/workflows/check-visual.yml | 13 ++++++++----- .github/workflows/check.yml | 7 +++++-- 7 files changed, 42 insertions(+), 21 deletions(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 485d65ff6..ccaebb73a 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -3,13 +3,16 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: check-build: timeout-minutes: 30 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 + - uses: actions/checkout@v6 + - uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" - name: Install dependencies @@ -21,7 +24,7 @@ jobs: - name: Run Playwright build smoke test run: npm run test:e2e -- --project chromium --config playwright.buildSmoke.config.ts - name: Upload artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 if: always() with: name: test-artifacts-${{ runner.os }} diff --git a/.github/workflows/check-e2e.yml b/.github/workflows/check-e2e.yml index 82a4f0a8e..43998c975 100644 --- a/.github/workflows/check-e2e.yml +++ b/.github/workflows/check-e2e.yml @@ -3,13 +3,16 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: check-e2e: timeout-minutes: 30 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 + - uses: actions/checkout@v6 + - uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" @@ -17,7 +20,7 @@ jobs: run: npm ci - name: Cache Playwright browsers - uses: actions/cache@v4 + uses: actions/cache@v5 id: playwright-dep-cache with: path: ~/.cache/ms-playwright @@ -36,7 +39,7 @@ jobs: run: npm run test:e2e -- --project chromium - name: Upload artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 if: always() with: name: test-artifacts-${{ runner.os }} diff --git a/.github/workflows/check-http-client-unit-test.yml b/.github/workflows/check-http-client-unit-test.yml index 018149376..b663ec1cc 100644 --- a/.github/workflows/check-http-client-unit-test.yml +++ b/.github/workflows/check-http-client-unit-test.yml @@ -3,14 +3,17 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: check-http-client-unit-test: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v6 - name: Setup Node - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" - run: npm ci diff --git a/.github/workflows/check-radicle-httpd.yml b/.github/workflows/check-radicle-httpd.yml index ea615fda3..5e16b8f52 100644 --- a/.github/workflows/check-radicle-httpd.yml +++ b/.github/workflows/check-radicle-httpd.yml @@ -3,6 +3,9 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: test: name: Build & Test @@ -11,7 +14,7 @@ jobs: run: working-directory: ./radicle-httpd steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: dtolnay/rust-toolchain@1.87 - uses: Swatinem/rust-cache@v2 with: @@ -29,7 +32,7 @@ jobs: run: working-directory: ./radicle-httpd steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: dtolnay/rust-toolchain@1.87 - uses: Swatinem/rust-cache@v2 with: @@ -45,7 +48,7 @@ jobs: run: working-directory: ./radicle-httpd steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: dtolnay/rust-toolchain@1.87 with: components: rustfmt, clippy diff --git a/.github/workflows/check-unit-test.yml b/.github/workflows/check-unit-test.yml index e8b422c91..a46ed2f71 100644 --- a/.github/workflows/check-unit-test.yml +++ b/.github/workflows/check-unit-test.yml @@ -3,14 +3,17 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: check-unit-test: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v6 - name: Setup Node - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" - run: npm ci diff --git a/.github/workflows/check-visual.yml b/.github/workflows/check-visual.yml index fc0e09e54..57e3dccdf 100644 --- a/.github/workflows/check-visual.yml +++ b/.github/workflows/check-visual.yml @@ -3,6 +3,9 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: generate-visual-diffs: concurrency: @@ -12,7 +15,7 @@ jobs: timeout-minutes: 30 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - name: Evict playwright snapshot cache when pushing to master run: | @@ -25,7 +28,7 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" @@ -33,14 +36,14 @@ jobs: run: npm ci - name: Cache Playwright browsers - uses: actions/cache@v4 + uses: actions/cache@v5 id: playwright-dep-cache with: path: ~/.cache/ms-playwright key: ${{ runner.os }}-playwright-${{ hashFiles('package-lock.json') }} - name: Cache Playwright visual snapshots - uses: actions/cache@v4 + uses: actions/cache@v5 id: playwright-snapshot-cache with: path: tests/visual/snapshots/**/* @@ -76,7 +79,7 @@ jobs: - name: Upload artifacts id: artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 if: always() with: name: test-artifacts-${{ runner.os }} diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 3a6811677..a1d30f35e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -3,13 +3,16 @@ on: push: workflow_dispatch: +env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true + jobs: check: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - name: Setup Node - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version-file: ".nvmrc" - run: npm ci