From 9dd3af0f9f810d2b284cb5d2a6505c5d6643b22a Mon Sep 17 00:00:00 2001 From: Thomas Scholtes Date: Mon, 10 Jul 2023 16:20:07 +0200 Subject: [PATCH] Cleanup shared peer and revision props for project route We move the `peer` and `revision` properties from the shared `ProjectLoadedParams` interface to the `tree` and `history` subroutes where they are needed. Signed-off-by: Thomas Scholtes --- src/views/projects/Commit.svelte | 3 +-- src/views/projects/View.svelte | 13 +++++++---- src/views/projects/router.ts | 39 ++++++++++++++++++++------------ 3 files changed, 34 insertions(+), 21 deletions(-) diff --git a/src/views/projects/Commit.svelte b/src/views/projects/Commit.svelte index 7f5b17700..8a32dfa0f 100644 --- a/src/views/projects/Commit.svelte +++ b/src/views/projects/Commit.svelte @@ -18,7 +18,6 @@ export let peer: string | undefined = undefined; export let peers: Remote[]; export let project: Project; - export let revision: string | undefined; export let view: LoadedSourceBrowsingView; const { commit: header } = commit; @@ -68,7 +67,7 @@ {contributorCount} {peers} {peer} - {revision} + revision={commit.commit.id} {view} />
diff --git a/src/views/projects/View.svelte b/src/views/projects/View.svelte index b70687576..99a51b377 100644 --- a/src/views/projects/View.svelte +++ b/src/views/projects/View.svelte @@ -20,8 +20,12 @@ export let project: Project; export let view: ProjectLoadedView; - export let peer: string | undefined = undefined; - export let revision: string | undefined = undefined; + let peer: string | undefined; + $: if (view.resource === "tree" || view.resource === "history") { + peer = view.peer; + } else { + peer = undefined; + }