From a4e0d21badbf561a7c483d74609b0745d4dc8d70 Mon Sep 17 00:00:00 2001 From: Sebastian Martinez Date: Thu, 20 Jun 2024 14:58:52 +0200 Subject: [PATCH] Reduce flakiness of some e2e tests --- src/views/projects/Header/SeedButton.svelte | 5 ++++- tests/e2e/project/commits.spec.ts | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/views/projects/Header/SeedButton.svelte b/src/views/projects/Header/SeedButton.svelte index 9e0f33737..e191ee7e8 100644 --- a/src/views/projects/Header/SeedButton.svelte +++ b/src/views/projects/Header/SeedButton.svelte @@ -8,7 +8,7 @@ import ErrorModal from "@app/modals/ErrorModal.svelte"; import ExternalLink from "@app/components/ExternalLink.svelte"; import IconSmall from "@app/components/IconSmall.svelte"; - import Popover from "@app/components/Popover.svelte"; + import Popover, { closeFocused } from "@app/components/Popover.svelte"; export let projectId: string; export let seedCount: number; @@ -100,6 +100,7 @@ on:click={async () => { if ($experimental && !seeding && canEditSeeding) { await editSeeding(); + closeFocused(); } else { toggle(); } @@ -121,6 +122,7 @@
{#if $experimental && canEditSeeding && seeding}
Stop seeding
@@ -134,6 +136,7 @@ disabled={editSeedingInProgress} on:click={async () => { await editSeeding(); + toggle(); }}> Stop seeding diff --git a/tests/e2e/project/commits.spec.ts b/tests/e2e/project/commits.spec.ts index c879099af..8ab07eeb9 100644 --- a/tests/e2e/project/commits.spec.ts +++ b/tests/e2e/project/commits.spec.ts @@ -17,6 +17,7 @@ test("peer and branch switching", async ({ page }) => { await page .getByRole("link", { name: `Commits ${aliceMainCommitCount}` }) .click(); + await expect(page.getByText("Thursday, December 15,")).toBeVisible(); // Alice's peer. { @@ -114,6 +115,7 @@ test("commit messages with double colon not converted into single colon", async exact: true, }) .click(); + await page.waitForLoadState("networkidle"); await expect(page.getByText(commitMessage, { exact: true })).toBeVisible(); });