From cc65aea3be91350559801bee48dcf6e7eddb9518 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= Date: Fri, 20 Nov 2026 10:57:34 +0100 Subject: [PATCH] desktop: Refresh lists once after context menu edits Each write already refreshes what it changed, so the menus' own refresh loaded the list a second time. --- desktop/src/components/IssueContextMenu.svelte | 6 +----- desktop/src/components/PatchContextMenu.svelte | 6 +----- desktop/src/lib/serialEdits.ts | 10 ++-------- desktop/src/views/repo/Issues.svelte | 1 - desktop/src/views/repo/Patches.svelte | 1 - 5 files changed, 4 insertions(+), 20 deletions(-) diff --git a/desktop/src/components/IssueContextMenu.svelte b/desktop/src/components/IssueContextMenu.svelte index 84eafe716..67d4dcfe1 100644 --- a/desktop/src/components/IssueContextMenu.svelte +++ b/desktop/src/components/IssueContextMenu.svelte @@ -26,7 +26,6 @@ repo: RepoInfo; config: Config; labelSuggestions: string[]; - onchange: () => Promise; onclose: () => void; } @@ -38,7 +37,6 @@ repo, config, labelSuggestions, - onchange, onclose, }: Props = $props(); @@ -57,7 +55,7 @@ ), ); - const enqueue = serialEdits("Editing issue failed", () => onchange()); + const enqueue = serialEdits("Editing issue failed"); function edit(action: Action) { const args = { @@ -75,7 +73,6 @@ cobId: issue.id, opts: { announce: $nodeRunning && $announce }, }; - const refresh = onchange; show({ component: ConfirmDeleteCob, props: { @@ -84,7 +81,6 @@ icon: "issue", confirm: async () => { await invoke("delete_issue", args); - await refresh(); }, }, }); diff --git a/desktop/src/components/PatchContextMenu.svelte b/desktop/src/components/PatchContextMenu.svelte index 91b287a55..53ed5452e 100644 --- a/desktop/src/components/PatchContextMenu.svelte +++ b/desktop/src/components/PatchContextMenu.svelte @@ -26,7 +26,6 @@ repo: RepoInfo; config: Config; labelSuggestions: string[]; - onchange: () => Promise; onclose: () => void; } @@ -38,7 +37,6 @@ repo, config, labelSuggestions, - onchange, onclose, }: Props = $props(); @@ -58,7 +56,7 @@ ), ); - const enqueue = serialEdits("Editing patch failed", () => onchange()); + const enqueue = serialEdits("Editing patch failed"); function edit(action: Action) { const args = { @@ -80,7 +78,6 @@ cobId: patch.id, opts: { announce: $nodeRunning && $announce }, }; - const refresh = onchange; show({ component: ConfirmDeleteCob, props: { @@ -89,7 +86,6 @@ icon: "patch", confirm: async () => { await invoke("delete_patch", args); - await refresh(); }, }, }); diff --git a/desktop/src/lib/serialEdits.ts b/desktop/src/lib/serialEdits.ts index abfeaa937..f15a53f6d 100644 --- a/desktop/src/lib/serialEdits.ts +++ b/desktop/src/lib/serialEdits.ts @@ -1,22 +1,16 @@ -// Runs edits one at a time in submission order and refreshes once the queue -// drains, so quick successive toggles neither race nor refresh per edit. +// Runs edits one at a time in submission order, so quick successive toggles +// don't race. Each write refreshes what it changed by itself. export function serialEdits( errorMessage: string, - refresh: () => Promise, ): (run: () => Promise) => void { let queue: Promise = Promise.resolve(); - let pending = 0; return run => { - pending += 1; queue = queue.then(async () => { try { await run(); } catch (error) { console.error(errorMessage, error); - } finally { - pending -= 1; - if (pending === 0) await refresh(); } }); }; diff --git a/desktop/src/views/repo/Issues.svelte b/desktop/src/views/repo/Issues.svelte index 9156f971c..ec59ae126 100644 --- a/desktop/src/views/repo/Issues.svelte +++ b/desktop/src/views/repo/Issues.svelte @@ -374,7 +374,6 @@ {repo} config={sidebarData.config} labelSuggestions={contextMenu.labelSuggestions} - onchange={refresh} onclose={contextMenu.close} /> {/if} diff --git a/desktop/src/views/repo/Patches.svelte b/desktop/src/views/repo/Patches.svelte index 437bc0fdc..b0206aa79 100644 --- a/desktop/src/views/repo/Patches.svelte +++ b/desktop/src/views/repo/Patches.svelte @@ -402,7 +402,6 @@ {repo} config={sidebarData.config} labelSuggestions={contextMenu.labelSuggestions} - onchange={refresh} onclose={contextMenu.close} /> {/if}