Improve catching of errors when loading routes

- Handle ResponseParseErros, ResponseErrors and normal errors
  differently.
- Show them all in the same `LoadError` view
- Add a subtitle to give users some more information on what could have
  gone wrong.
- Add more properties to the copyable error message to make debugging
  easier.
This commit is contained in:
Sebastian Martinez
2024-02-15 13:26:11 -03:00
parent 8450f0cd9c
commit d216caec7d
24 changed files with 389 additions and 185 deletions
+23
View File
@@ -40,3 +40,26 @@ test("load error", async ({ page }) => {
await page.goto("/", { waitUntil: "networkidle" });
await expect(page).toHaveScreenshot();
});
test("response parse error", async ({ page }) => {
await page.addInitScript(appConfigWithFixture);
await page.route("*/**/v1/projects*", route => {
return route.fulfill({
json: [{ name: 1337 }],
});
});
await page.goto("/", { waitUntil: "networkidle" });
await expect(page).toHaveScreenshot();
});
test("response error", async ({ page }) => {
await page.addInitScript(appConfigWithFixture);
await page.route("*/**/v1/projects*", route => {
return route.fulfill({
status: 500,
body: "There is an error in the response",
});
});
await page.goto("/", { waitUntil: "networkidle" });
await expect(page).toHaveScreenshot();
});
+26
View File
@@ -37,3 +37,29 @@ test("node not found", async ({ page }) => {
});
await expect(page).toHaveScreenshot();
});
test("response parse error", async ({ page }) => {
await page.route("*/**/v1/projects*", route => {
return route.fulfill({
json: [{ name: 1337 }],
});
});
await page.goto("/nodes/radicle.local", {
waitUntil: "networkidle",
});
await expect(page).toHaveScreenshot();
});
test("response error", async ({ page }) => {
await page.route("*/**/v1/projects*", route => {
return route.fulfill({
status: 500,
});
});
await page.goto("/nodes/radicle.local", {
waitUntil: "networkidle",
});
await expect(page).toHaveScreenshot();
});
+21
View File
@@ -5,6 +5,7 @@ import {
sourceBrowsingUrl,
aliceRemote,
markdownUrl,
sourceBrowsingRid,
} from "@tests/support/fixtures.js";
test("source page", async ({ page }) => {
@@ -99,6 +100,26 @@ test("project not found", async ({ page }) => {
await expect(page).toHaveScreenshot();
});
test("response parse error", async ({ page }) => {
await page.route(`*/**/v1/projects/${sourceBrowsingRid}`, route => {
return route.fulfill({
json: [{ name: 1337 }],
});
});
await page.goto(sourceBrowsingUrl, { waitUntil: "networkidle" });
await expect(page).toHaveScreenshot();
});
test("response error", async ({ page }) => {
await page.route(`*/**/v1/projects/${sourceBrowsingRid}`, route => {
return route.fulfill({
status: 500,
});
});
await page.goto(sourceBrowsingUrl, { waitUntil: "networkidle" });
await expect(page).toHaveScreenshot();
});
test("readme not found", async ({ page }) => {
await page.goto(`${markdownUrl}/tree`, {
waitUntil: "networkidle",