From d4b246c72de7cd47034bff1cd2ce56b97f89d221 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C5=ABdolfs=20O=C5=A1i=C5=86=C5=A1?= <rudolfs@osins.org>
Date: Fri, 16 Feb 2024 17:22:43 +0000
Subject: [PATCH] Tweak issue/patch validation rules

Patches - title: mandatory, body: optional.
Issues - title and body: mandatory.
---
 src/components/ExtendedTextarea.svelte | 11 ++++++++---
 src/views/projects/Issue.svelte        |  2 ++
 src/views/projects/Issue/New.svelte    |  2 ++
 src/views/projects/Patch.svelte        |  2 +-
 4 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/components/ExtendedTextarea.svelte b/src/components/ExtendedTextarea.svelte
index 618d6750a..bcae687e9 100644
--- a/src/components/ExtendedTextarea.svelte
+++ b/src/components/ExtendedTextarea.svelte
@@ -25,7 +25,10 @@
   export let body: string = "";
   export let embeds: Map<string, Embed> = new Map();
   export let submitInProgress: boolean = false;
-  export let validateBody: boolean = true;
+  export let disallowEmptyBody: boolean = false;
+  export let isValid: () => boolean = () => {
+    return true;
+  };
 
   let preview: boolean = false;
   let selectionStart = 0;
@@ -178,7 +181,7 @@
     </Button>
     <Button
       styleBorderRadius="0"
-      disabled={validateBody && !body}
+      disabled={!isValid()}
       variant={preview ? "selected" : "not-selected"}
       on:click={() => {
         preview = true;
@@ -235,7 +238,9 @@
       </Button>
       <Button
         variant="secondary"
-        disabled={(validateBody && !body) || submitInProgress}
+        disabled={!isValid() ||
+          submitInProgress ||
+          (disallowEmptyBody && body.length === 0)}
         on:click={submit}>
         {#if submitInProgress}
           <Loading small noDelay />
diff --git a/src/views/projects/Issue.svelte b/src/views/projects/Issue.svelte
index 235b0a867..313022f66 100644
--- a/src/views/projects/Issue.svelte
+++ b/src/views/projects/Issue.svelte
@@ -542,6 +542,8 @@
         <div slot="description">
           {#if issueState !== "read"}
             <ExtendedTextarea
+              isValid={() => newTitle.length > 0}
+              disallowEmptyBody
               rawPath={rawPath(project.head)}
               enableAttachments
               embeds={parseEmbedIntoMap(issue.discussion[0].embeds)}
diff --git a/src/views/projects/Issue/New.svelte b/src/views/projects/Issue/New.svelte
index 38709a4df..6d809cc9f 100644
--- a/src/views/projects/Issue/New.svelte
+++ b/src/views/projects/Issue/New.svelte
@@ -99,6 +99,8 @@
           <svelte:fragment slot="description">
             <ExtendedTextarea
               rawPath={rawPath(project.head)}
+              disallowEmptyBody
+              isValid={() => issueTitle.length > 0}
               enableAttachments
               submitCaption="Submit"
               placeholder="Write a description"
diff --git a/src/views/projects/Patch.svelte b/src/views/projects/Patch.svelte
index 492ee9dbd..4f1812f87 100644
--- a/src/views/projects/Patch.svelte
+++ b/src/views/projects/Patch.svelte
@@ -766,7 +766,7 @@
           <div class="revision-description">
             {#if session && patchState !== "read" && latestEdit}
               <ExtendedTextarea
-                validateBody={false}
+                isValid={() => patch.title.length > 0}
                 enableAttachments
                 embeds={parseEmbedIntoMap(latestEdit.embeds)}
                 rawPath={rawPath(patch.revisions[0].id)}