From e5ec6e33fb584e0598ef27cb5a6df7d9e97fed88 Mon Sep 17 00:00:00 2001 From: Sebastian Martinez Date: Thu, 13 Apr 2023 10:32:58 +0200 Subject: [PATCH] Improve general UX - Hide issue title edit button when not logged in - Show Blob placeholder when empty file - Allow selecting blob code without the lines - Add Clipboard component to object id in CobHeader - Add blockies to Patch and Issueteasers - Reduce formatted object ids to 7 instead of 11 chars - Remove line breaking on soft wraps from Markdown - Reduce font size of code blocks in Markdown - Improve margins in IssueTeaser - Reduce font size in FileDiffs - Improve teasers, assignees and tags highlighting - Reduce font size of code - Change commit teaser subtitle - Show Clipboard in commit sha1 - Add blockies to PeerSelector - Adjust commit view CSS Signed-off-by: Sebastian Martinez --- public/layout.css | 10 +++- src/components/Authorship.svelte | 19 ++----- src/components/Comment.svelte | 2 +- src/components/Dropdown.svelte | 23 ++++---- src/components/Markdown.svelte | 5 +- src/lib/utils.ts | 2 +- src/views/projects/Blob.svelte | 8 ++- src/views/projects/Cob/AssigneeInput.svelte | 4 +- src/views/projects/Cob/CobHeader.svelte | 16 ++++-- src/views/projects/Cob/CobStateButton.svelte | 2 +- src/views/projects/Cob/TagInput.svelte | 4 +- src/views/projects/Commit.svelte | 12 ++-- .../projects/Commit/CommitAuthorship.svelte | 3 +- src/views/projects/Issue.svelte | 4 +- src/views/projects/Issue/IssueTeaser.svelte | 21 ++----- src/views/projects/Patch.svelte | 23 +++----- src/views/projects/Patch/PatchTeaser.svelte | 24 +++----- src/views/projects/PeerSelector.svelte | 55 +++++++++++++------ .../projects/SourceBrowser/FileDiff.svelte | 1 + 19 files changed, 124 insertions(+), 114 deletions(-) diff --git a/public/layout.css b/public/layout.css index fcfdee620..31b358fd7 100644 --- a/public/layout.css +++ b/public/layout.css @@ -9,7 +9,8 @@ } .layout-mobile, -.layout-mobile-inline { +.layout-mobile-inline, +.layout-mobile-flex { display: none !important; } .layout-desktop { @@ -18,6 +19,9 @@ .layout-desktop-inline { display: inline !important; } +.layout-desktop-flex { + display: flex !important; +} @media (max-width: 720px) { .layout-mobile { @@ -26,7 +30,11 @@ .layout-mobile-inline { display: inline !important; } + .layout-mobile-flex { + display: flex !important; + } .layout-desktop, + .layout-desktop-flex, .layout-desktop-inline { display: none !important; } diff --git a/src/components/Authorship.svelte b/src/components/Authorship.svelte index 69d04c577..9a44f4712 100644 --- a/src/components/Authorship.svelte +++ b/src/components/Authorship.svelte @@ -4,7 +4,6 @@ export let authorId: string; export let caption: string | undefined = undefined; - export let highlight: boolean = false; export let noAvatar: boolean = false; export let timestamp: number | undefined = undefined; @@ -16,7 +15,7 @@ .authorship { display: inline-flex; align-items: center; - color: var(--color-foreground-5); + color: var(--color-foreground-6); padding: 0.125rem 0; } .id { @@ -26,26 +25,18 @@ } .body { margin: 0 0.4rem; - color: var(--color-foreground-5); white-space: nowrap; } - .highlight { - color: var(--color-foreground-6); - font-weight: var(--font-weight-bold); - } - .date { - color: var(--color-foreground-6); - } {#if !noAvatar} {/if} - + {formatNodeId(authorId)} - + {formatNodeId(authorId).replace("did:key:", "")} @@ -56,8 +47,6 @@ {/if} {#if timestamp} - - {formatTimestamp(timestamp)} - + {formatTimestamp(timestamp)} {/if} diff --git a/src/components/Comment.svelte b/src/components/Comment.svelte index 0b23f3b74..170a6dcb4 100644 --- a/src/components/Comment.svelte +++ b/src/components/Comment.svelte @@ -83,7 +83,7 @@ {:else if body.trim() === ""} No description. {:else} - + {/if} diff --git a/src/components/Dropdown.svelte b/src/components/Dropdown.svelte index 440b9b1de..4db9c2d6e 100644 --- a/src/components/Dropdown.svelte +++ b/src/components/Dropdown.svelte @@ -1,6 +1,5 @@