From ebfec3fd8e20eb09b2ea79560def38f8e5246b6b Mon Sep 17 00:00:00 2001 From: Sebastian Martinez Date: Thu, 1 Feb 2024 14:08:28 +0100 Subject: [PATCH] Set Revision expanded state only on first mount Instead of recalculating the expanded state of a revision on any `patch.revisions` variable change, we should just use it once on Mount and then let the `Revision` component manage their expanded state internally. --- src/views/projects/Cob/Revision.svelte | 3 ++- src/views/projects/Patch.svelte | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/views/projects/Cob/Revision.svelte b/src/views/projects/Cob/Revision.svelte index a2f1c186a..614dc3fce 100644 --- a/src/views/projects/Cob/Revision.svelte +++ b/src/views/projects/Cob/Revision.svelte @@ -32,7 +32,7 @@ import Thread from "@app/components/Thread.svelte"; export let baseUrl: BaseUrl; - export let expanded: boolean = false; + export let initialExpanded: boolean = false; export let rawPath: (commit?: string) => string; export let patchId: string; export let patchState: PatchState; @@ -64,6 +64,7 @@ | ((commentId: string, comment: string, embeds: Embed[]) => Promise) | undefined; + let expanded = initialExpanded; const api = new HttpdClient(baseUrl); const latestEdit = revisionEdits.pop(); diff --git a/src/views/projects/Patch.svelte b/src/views/projects/Patch.svelte index 97a11a990..2e4f916e5 100644 --- a/src/views/projects/Patch.svelte +++ b/src/views/projects/Patch.svelte @@ -888,7 +888,7 @@ partial(createReply, session.id, revision.revisionId)} patchId={patch.id} patchState={patch.state} - expanded={index === patch.revisions.length - 1} + initialExpanded={index === patch.revisions.length - 1} previousRevId={previousRevision?.id} previousRevOid={previousRevision?.oid}> {#if index === patch.revisions.length - 1}