Commit Graph
97 Commits
Author SHA1 Message Date
Sebastian Martinez 5e5f7fc12f Add editing to issue/patch descriptions, comments and replies
Also does some refactoring for `action`, `editable` and other variables
we were using which weren't very clear

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-26 16:27:54 +02:00
Sebastian Martinez 809daadd04 Remove search functionality
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-26 13:22:01 +02:00
Rūdolfs Ošiņš 16a1821fff Update Track button copy
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-26 10:09:22 +02:00
Rūdolfs Ošiņš 6f4f7894a3 Implement sticky file headers
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-20 09:34:55 +02:00
Sebastian Martinez 580ccbcf1a Invert markdown plain buttons in Blob component
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-16 11:17:13 +02:00
Rūdolfs Ošiņšanddnlklmn d914710396 Implement new design
Co-authored-by: dnlklmn <pelicansinberlin@gmail.com>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-13 18:05:19 +02:00
Sebastian Martinez 1ef0f9dfd1 Add issue embeds
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-27 16:40:49 +02:00
Sebastian Martinez 6e17d98d96 Reduce test flakiness on global hotkeys
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-26 09:43:09 +02:00
Sebastian Martinez bd6ba784b3 Improve binary detection
libgit2 optimizes around not loading the content, when there's no
content callbacks configured.

So we aren't able to get a clear answer from radicle-surf if a file in a
diff is a binary or not.

A simple way without doing additional API requests is to check if the
file type is a executable and if there are no hunks (since we don't get
any deltas in binaries), this is a strong
indicator for a binary.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-26 09:04:01 +02:00
Sebastian Martinez 9b15911f83 Use lastCommit of each blob for navigation instead of patch revision
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-25 10:07:14 +02:00
Sebastian Martinez fb06b5fe8b Add moved and copied files e2e tests
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:50:27 +02:00
Alice Liddell 1b01216bf8 Improve FileDiff and add tests
Signed-off-by: Alice Liddell <alice@radicle.xyz>
2023-09-19 07:49:36 +02:00
Sebastian Martinez afab097d09 Delay global hotkeys tiping speed to imitate real user
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:45:40 +02:00
Sebastian Martinez 1a7c28b6ea Split going through UI patch flow into separate tests
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:45:40 +02:00
Sebastian Martinez 45830f6cd9 Show local projects instead of network to landing page, if available
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-04 12:06:03 +02:00
Sebastian Martinez 542630a7f7 Add patch comment and state modifiers
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-30 17:05:25 +02:00
Sebastian Martinez aec0289f10 Refactor some of the reaction components
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:52:57 +02:00
Sebastian Martinez 26447b3c59 Switch edit title button with icons
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:34:57 +02:00
Rūdolfs Ošiņš 3bd13196d9 Add icons to browser file tree
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-28 12:03:19 +02:00
Sebastian Martinez ea1f23c4a2 Add test to check that issue counter updates when closing issue
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 09:18:07 +02:00
Rūdolfs Ošiņš 34b2f569c1 Improve node error handling
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-24 09:42:17 +02:00
Sebastian Martinez 7edd6dcdf0 Enable adding and removing reactions
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-24 09:23:36 +02:00
Rūdolfs Ošiņš 0146ca00b5 Update the UI to work with the new COB schema
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 10:53:49 +02:00
Sebastian Martinez 4525771264 Use /nodes/ in URL instead of /seeds/
We still allow already published URLs with `/seeds/` in them to be
resolved.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-31 16:58:45 +02:00
Sebastian Martinez 910c103a9b Change rad web command when httpd port changes
Instead of using always the `config.seeds.defaultHttpdPort` which is
443, we should take into account the `customPort` variable that is set by the
user.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-31 15:38:36 +02:00
Sebastian Martinez 99ec07e0a3 Add e2e tests for patch and issue counters
When creating a new patch or issue, we want the counters to reflect on
that on navigation.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-31 10:16:41 +02:00
Rūdolfs OšiņšandThomas Scholtes 391f188b69 Fix navigating to history when a file is selected
Co-authored-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-26 14:17:18 +02:00
Sebastian Martinez f631c7f171 Fix absolute links with files in markdown
We had a regression because of introducing marked-linkify-it, which took
links for CONTRIBUTING.md or HACKING.md as domains of a new page instead
than files to be navigating to.

This commit sets the `fuzzyLink` option for marked-linkify-it to false,
which disables this behavior

Also tests that the browser tree expands itself when navigating to a
file inside a directory

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-22 08:02:00 +02:00
xphoniex 5ee8c8281b Make diff line selectable and shareable
Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-20 11:37:57 +02:00
Sebastian Martinez afbc57079b Switch page.locator with page.getByRole and page.getByText
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 11:35:20 +02:00
Sebastian Martinez 6151729a6d Add empty file test case
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 11:35:20 +02:00
Thomas Scholtes 283b665b31 Switch to flat project route type
We switch to a project route type that is just a union. This has the
following advantages

* It’s much easier to construct project routes. Fewer properties are
  needed and there are no nested objects.
* We eliminate the implicitly shared properties `path`, `peer`,
  `revision` and `route` which only belonged to the tree route.
* The structure of the project route is more regular and thus easier to
  understand.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-17 11:27:57 +02:00
Thomas Scholtes 684700a24d Don’t flood Playwright traces with route.continue()
We determine URLs to mock with a URL matcher instead of mocking every
URL and determining the behavior in the route handler. This should be
slightly faster and should result in better debugging experience because
we don’t come across the `route.continue()` event that often.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-14 09:29:19 +02:00
Thomas Scholtes f80b193bbd Don’t intercept navigation to external URLs in Markdown
Fixes 928

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-14 09:29:19 +02:00
Sebastian Martinez 205fc814bc Bring reactions to comments and issues
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 15:36:02 +02:00
Sebastian Martinez 28718ba0cf Add --alias to rad auth
To avoid the popping up of a terminal input field during the
globalFixture setup, we need to pass the wanted alias as a flag.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 15:36:02 +02:00
Sebastian Martinez 9294e23ea4 Update patch review schemas
To address changes to patch code review,
implemented in Heartwood in commit 45e87a6.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-11 13:59:23 +02:00
Thomas Scholtes f3e5b47124 Don’t replace path on internal navigation
We don’t replace the path when we navigate internally. This means we
keep the hash part of the URL even if it is not part of the route and we
can remove the workaround for that.

This also means that we keep the original URL if the parsed route would
result in a different URL. This change is visible through a slight
adjustments in the tests.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-09 14:46:26 +02:00
Sebastian Martinez db94969f8a Allow httpd API ports to be generated randomly.
To avoid port collisions between tests that can eventually run in
parallel, we need to be able to generate random port numbers.

This commit generates random httpd port numbers for inline tests,
while keeping the current palm seed with the default port number 8080.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-09 14:19:47 +02:00
Thomas Scholtes 092f8ad774 Don’t leave line selected when switching blobs
Fixes #906

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-07 07:41:51 +02:00
Sebastian Martinez 91f5abafd3 Add a UI test flow for issues
Tests:
- Authentication
- Issue creation
- Title editing
- Commenting
- Reply to comment
- Issue state change

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-05 13:48:42 +02:00
Sebastian Martinez e0261fe69e Add more comments and replies and a rejected review to the test fixtures
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-04 14:52:51 +02:00
Sebastian Martinez 0cd42908e5 Add error handling for issue creation and commenting
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-04 14:14:29 +02:00
Rūdolfs Ošiņš 4c101c2567 Move Blob loading into router
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-06-28 17:07:04 +02:00
Sebastian Martinez 742a8eb1ef Add spec for expanding commit message
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-06-28 15:45:01 +02:00
Sebastian Martinez f971d777f2 Add missing moved and copied file operations to Changeset
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2022-11-17 17:50:19 +01:00
Rūdolfs Ošiņš 3f7a58c489 Handle app URL translation into seed BaseUrl in one place
To make the code easier to reason about we handle all app URL encoding
and decoding and the related seed BaseUrl extraction in a single place.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-06-28 10:51:59 +02:00
Sebastian Martinez 0e6be19373 Add patch reviewers in sidebar
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-06-27 17:23:37 +02:00
Sebastian Martinez ba57506d6d Update svelte to version 4
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-06-26 14:13:22 +02:00
Sebastian Martinez 52cece4680 Handle custom httpd port
We only supported fetching the default httpd port (8080).
This commit removes navigation to `radicle.local` which represents
`0.0.0.0:8080`, and prepares the app for defining custom port.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-06-14 16:17:21 +02:00