Commit Graph
2123 Commits
Author SHA1 Message Date
cloudhead 7a641aead5 httpd: Fix clippy warning
Note: because we don't have a working copy here, we can't call
`Merged::cleanup`. We need to figure something out for this.
2023-09-01 15:16:56 +02:00
cloudhead d565a039e4 node: Implement private repos
Private repos are implemented by extending the identity document with a
`visibility` attribute, that can either be `"public"` (default) or
`"private"`.

In case of `private` visibility, only the delegates are allowed to view
the repo, as well as any DIDs added to the allow list.

To implement repo visibility, we simply block fetches from and
announcements to peers for whom the repo should remain invisible.

Private repos are also not announced in the `inventory` message, since
the full list of peers that *may* have the repo is retrievable from the
repo identity. This could cause errors if eg. a peer who is allowed to
view the repo doesn't actually have it. However this is an ok trade-off
for now to keep the complexity low. For repos to truly be private, it's
important that the RIDs don't leak either.

Finally, we modify `radicle-httpd` for now to only list public repos.
Eventually, we would want to change this depending on whether an allowed
peer is authenticated with the service or not.

---

It's also worth mentioning why this approach was taken, vs. end-to-end
encryption. The reasons are as follows:

1. Nodes that do not have access to a private repo will generally not want to
   replicate encrypted data that they cannot examine or use.
2. The chosen solution is trivial, while encrypting git objects isn't.
3. Performance of the chosen solution is much better, there is no
   overhead.
4. Privacy of the chosen solution is better: RIDs are never leaked, and
   neither is the existence of a private repo, nor who has access to it.

There is one downside: Paying for storage of private repos is no better
in terms of privacy than what GitHub offers. Hosting providers will have
access to your private repos, if this solution is used.
2023-09-01 12:13:45 +02:00
Sebastian Martinez 542630a7f7 Add patch comment and state modifiers
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-30 17:05:25 +02:00
Vincenzo Palazzo e9da55c8a7 httpd: Enable the clock feature in chrono
Currently, radicle-httpd does not compile without this.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-08-29 11:33:39 +02:00
Sebastian Martinez aec0289f10 Refactor some of the reaction components
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:52:57 +02:00
Sebastian Martinez 26447b3c59 Switch edit title button with icons
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:34:57 +02:00
Rūdolfs Ošiņš 3bd13196d9 Add icons to browser file tree
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-28 12:03:19 +02:00
Sebastian Martinez ea1f23c4a2 Add test to check that issue counter updates when closing issue
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 09:18:07 +02:00
Rūdolfs Ošiņš 6e049197ef Remove apple-touch-icon from index.html
Firefox uses it as favicon by mistake, this icon has a black background
and is only intended for apple homescreen. It should be enough to just
have the filename for apple devices.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-24 17:54:23 +02:00
Rūdolfs Ošiņš 34b2f569c1 Improve node error handling
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-24 09:42:17 +02:00
Sebastian Martinez 1efeb41667 Add face Icon
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-24 09:23:36 +02:00
Sebastian Martinez def558033c Add ability to install local binaries
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-24 09:23:36 +02:00
Sebastian Martinez 7edd6dcdf0 Enable adding and removing reactions
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-24 09:23:36 +02:00
Rūdolfs Ošiņš 3eecaeda29 Use proper issue icon for issues
The exclamation mark looked too much like a warning or error.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-23 15:09:20 +02:00
Sebastian Martinez b079b7f51a Update node version to 18.17.1
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-23 14:33:30 +02:00
Sebastian Martinez 08683dc9e9 Update deps
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-23 10:07:15 +02:00
Sebastian Martinez b164b19494 httpd: Add reactions and edits to patches
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-22 14:42:09 +02:00
cloudhead cdfb1182ab Introduce cargo-deny
Add `deny.toml` with a few exceptions, and update certain dependencies
to get rid of duplicates.

Running `cargo deny check` will yield some warnings still, but no
errors.
2023-08-22 14:33:00 +02:00
cloudhead 237e1e9adb cob: Add support for media embeds in COBs
This change allows for files (blobs) to be embedded into COB entries.
This allows for things like image attachments in issue comments for example.

For now, we only enable this in the `issue` COB.

The way it works is that relevant COB actions carry metadata about which
files are attached to them; and we store those files as blobs inside the
COB entry's *tree* object, under an `embeds/` folder.

The `Embed<T>` type is used for the above, and either carries actual
content, or carries a content-id. Retrieving the actual content is as
simple as asking the repository for a blob with that content-id.

As a possible future extension, MIME types could be stored alongside the
files in a "metadata" file. This could help clients display the content
appropriately.
2023-08-22 14:29:23 +02:00
Sebastian Martinez 289cf24800 Update heartwood-version
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-22 09:54:41 +02:00
Sebastian Martinez cccee12477 Add a NodeConfigurator class, to modify a config.json
Since Heartwood is removing some of the radicle-node options we were
relying on when starting nodes for our tests, we need to move those to
the `config.json` file.

To make it more DX friendly, I added a `NodeConfigurator` class which
reads the correspondig `config.json`, stores it and allows to configure
it before starting a node.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-22 09:54:34 +02:00
Sebastian Martinez 3dd590d8e6 Add key to each loop in project listing
Without a key we started to get an erratic behavior when adding more
projects and then sorting them.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-17 13:14:52 +02:00
Sebastian Martinez 2c81228db6 Sort node projects by HEAD commit time
Instead of going with project activity which is being stripped
everything that is older than one year, we should look at the current
project head time.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-17 11:29:19 +02:00
Rūdolfs Ošiņš 0c0842e6f3 Fix project sorting on node page when there is no activity data
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-16 12:55:39 +02:00
Rūdolfs Ošiņš 492ff5b07c Properly handle event streams with readline
The stream would otherwise split longer events into multiple chunks
which would fail to parse.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-16 09:41:43 +02:00
Rūdolfs Ošiņš 5736083d50 Fix not found and loading error screens
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-16 09:35:44 +02:00
Rūdolfs Ošiņš 0e33915e9a Fix visual tests
This was failing on master, so the visual spec cache didn't get updated.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-15 14:05:53 +02:00
Sebastian Martinez 18a5d40b0a Modify network property in config.json to test
To avoid the test nodes to try to connect to the main network,
we need to modify the `config.json` of each node to use the `test`
network

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-15 13:25:42 +02:00
Sebastian Martinez 30ecfd81fa httpd: Allow removing of reactions from issues
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-14 16:41:04 +02:00
Sebastian Martinez 6a1137a024 Add parents property to CommitHeader type
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-14 11:33:00 +02:00
cloudhead a2c84f36bf httpd: Fix more routes that return the wrong code
These routes should return 404 if the entity was not found.
2023-08-09 16:59:19 +02:00
Rūdolfs Ošiņš fa89d75b1f Pin radicle-homepage and radicle-tui to the landing page
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-09 15:30:20 +02:00
cloudhead 1a81c704bc httpd: Fix error status code on project not found
It was 500, should be 404.
2023-08-09 12:01:14 +02:00
Rūdolfs Ošiņš c2031933b3 Update dependencies
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-09 11:09:18 +02:00
Rūdolfs Ošiņš a3325b70c4 Simplify layout CSS
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 17:40:43 +02:00
Rūdolfs Ošiņš 449ed1d79b Simplify project header props
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 17:40:43 +02:00
Rūdolfs Ošiņš fc87a8822a Get rid of ProjectMeta component by moving it into Layout
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 17:40:43 +02:00
Rūdolfs Ošiņš 3bb56e6613 Organize project components
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 17:40:43 +02:00
Rūdolfs Ošiņš 5cd098187c Rename "project.tree" to "project.source"
This aligns better with the component and tab naming.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 15:35:27 +02:00
Rūdolfs Ošiņš 3cc485dce2 Flatten ProjectLoadedRoute type
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 15:24:26 +02:00
Rūdolfs Ošiņš d39fee871d Move project view into App.svelte
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 14:50:58 +02:00
Rūdolfs Ošiņš 723509a267 Extract top-level menu into a layout
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 14:40:45 +02:00
Rūdolfs Ošiņš 0146ca00b5 Update the UI to work with the new COB schema
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-08 10:53:49 +02:00
Alexis Sellier 3ddec3dd7d cob: Stabilize formats
> I'm going to be making a set of breaking changes to COBs in order to
stabilize the data formats. This is hopefully a one-time change that
bundles various breaking changes.

All COBs have been reworked: issue, patch, id.

The changes included are:

* Revise the assign and tag actions to take a single list of
  assignees/tags to set, instead of an "add" and a "remove" list. This
  makes API usage simpler when editing issues, and simplifies the apply
  function
* Rename "tags" to "labels", and the tag action to label. This is
  because tag is confusing in the context of git, as it could mean a git
  tag. Using label removes that confusion.
* Use DIDs instead of PublicKeys for assignees -- this is more
  future-proof
* Modify the manifest file format in the COB tree. Mainly, remove the
  `history_type` key which is redundant, and use camelCase for keys
* Flatten the `Thread` actions into the parent action type
* Ensure that operations on redacted objects do not fail, since
  redactions could have happened concurrently
* Use a consistent naming scheme for actions, using `.` as separator
* Consolidate comment types and remove `CodeComment`, by adding an
  optional `location` field to `Comment`
* Add many placeholder actions that are not yet implemented

To preserve backwards compatibility, a `legacy` module is created with
the old `apply` function. When loading the manifest, we check whether it
is a legacy COB or a "stable" COB, and in the legacy case, use the
legacy code to materialize the state and then convert the object into
the stable type. Eventually, we'll delete the legacy code.
2023-08-07 11:05:14 +02:00
Slack Coder 1e4c354972 docker: Make Dockerfile easier to read
Avoid long lines by separating commands and arguments with '\'.
2023-08-03 13:43:20 +02:00
Sebastian Martinez df2251f6ee httpd: Add socketAddress to /node endpoint
This allows us in the web client to show and let user copy the node id
together with the correct port number

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-03 13:30:55 +02:00
Rūdolfs Ošiņš 0d024759d3 Upgrade to the latest heartwood version
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-01 16:41:22 +02:00
Alexis Sellier d45cce1df5 Use numbers for LocalTime timestamps
Instead of using strings, use numbers.

*This is a breaking change and affects `config.json` parsing.*

To upgrade, simply unquote any number in your `config.json`.
2023-08-01 15:47:02 +02:00
Thomas Scholtes cbe1fa5c9a Simplify and align project view props
We simplify the properties of the project views `Issue`, `Issues`,
`NewIssue`, and `Patch`. This aligns them with other project views and
makes the view selection consistent.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-31 17:53:30 +02:00
Thomas Scholtes 8acb2410d5 Remove redundant project route parameters
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-31 17:33:43 +02:00