Rūdolfs Ošiņš
84995442a5
ADR 2 now only covers how the apps consume shared code, so its notes on the extraction strategy move here. All three root ADRs are accepted with this patch.
1.6 KiB
2. Shared front-end code in an npm workspace
Date: 2026-10-21
Status
Accepted
Context
Desktop and explorer have copied a lot of front-end code from each other. This ADR decides how both apps consume shared code; ADR 3 decides what moves into it and in which shape.
We also considered consuming shared/ui as a plain source folder and as a
local file: dependency. Both need workarounds in each app's Vite and
TypeScript config, and leave shared/ui without its own lints and tests.
Decision
A root npm workspace holds shared/ui, explorer and desktop, with one
lockfile, .npmrc and .nvmrc at the root.
shared/ui is the package @radicle-gui/ui. It has svelte as a peer
dependency and its own checks, lints, tests and CI workflow. The apps depend on
it and import it from source, without a build step.
Shared stylesheets and fonts live in shared/ui/public. A Vite plugin from the
package serves them next to each app's public directory in dev and adds them
to the build, so the apps keep their <link> tags, marked vite-ignore.
Consequences
- The apps share one dependency tree. Shared code gets a single copy of
svelteand its other dependencies, and is checked and tested on its own, without workarounds in either app. - Dependency versions are coupled. Where the apps' ranges overlap, a bump lands in both, and an app that needs to diverge has to pin its own version.
- Installs and builds start from the repository root. Working on one app means
installing it with
-w, and Nix, Docker and CI have to use the root lockfile.