Files
radicle-explorer/src/components/Thread.svelte
T
Rūdolfs Ošiņš 2c9c382073 Say who resolved a comment
The comment records only that it is resolved, so the name comes from the
resolve operation in the patch's log. Adds the action to timeline
threads too, and shapes the badge like a review's verdict.
2026-08-14 17:30:46 +02:00

307 lines
9.7 KiB
Svelte

<script lang="ts">
import type { CommentOrigin } from "@app/components/Comment.svelte";
import type { Author } from "@bindings/cob/Author";
import type { CodeLocation } from "@bindings/cob/thread/CodeLocation";
import type { Embed } from "@bindings/cob/thread/Embed";
import type { Thread } from "@bindings/cob/thread/Thread";
import type { Snippet } from "svelte";
import { tick } from "svelte";
import type { Resolution } from "@app/lib/commentResolutions";
import { formatResolvedCaption, scrollIntoView } from "@app/lib/utils";
import CommentComponent from "@app/components/Comment.svelte";
import ExtendedTextarea from "@app/components/ExtendedTextarea.svelte";
import Icon from "@app/components/Icon.svelte";
interface Props {
thread: Thread<CodeLocation>;
rid: string;
currentUserNid?: string;
// Whether the current user may edit or delete a comment by this author.
// The protocol reserves both for the comment's own author.
canModifyComment: (author: string) => true | undefined;
editComment?: (
commentId: string,
body: string,
embeds: Embed[],
) => Promise<void>;
createReply?: (
comment: string,
embeds: Embed[],
commentId: string,
) => Promise<void>;
reactOnComment?: (
commentId: string,
authors: Author[],
reaction: string,
) => Promise<void>;
deleteComment?: (commentId: string) => Promise<void>;
changeCommentStatus?: (
commentId: string,
resolved: boolean,
) => Promise<void>;
canResolve?: boolean;
// Set for threads rendered inside a diff, where there is no surrounding
// activity timeline for the outer rail to connect to.
inline?: boolean;
draft?: boolean;
origin?: CommentOrigin;
// Rendered on the root comment's authorship line while it is hovered. The
// replies do not get it: it says something about the thread, not a comment.
hoverNote?: Snippet;
// A single comment to ring, so a jump from elsewhere can say where it
// landed. Marks that one comment, root or reply, not the thread around it.
highlightedCommentId?: string;
// Who resolved a comment, for its badge to name. Looked up rather than read
// off the comment, which carries only the flag (see `resolutionsByComment`).
resolvedBy?: (commentId: string) => Resolution | undefined;
}
const {
thread,
rid,
currentUserNid,
canModifyComment,
editComment,
createReply,
reactOnComment,
deleteComment,
changeCommentStatus,
canResolve = false,
inline = false,
draft = false,
origin,
hoverNote,
highlightedCommentId,
resolvedBy,
}: Props = $props();
function resolvedCaption(commentId: string): string | undefined {
const resolution = resolvedBy?.(commentId);
return (
resolution &&
formatResolvedCaption(resolution.author, resolution.timestamp)
);
}
async function toggleReply() {
showReplyForm = !showReplyForm;
if (!showReplyForm) {
return;
}
await tick();
scrollIntoView(`reply-${root.id}`, {
behavior: "smooth",
block: "center",
});
}
let showReplyForm = $state(false);
let submitInProgress = $state(false);
const root = $derived(thread.root);
const replies = $derived(thread.replies);
</script>
<style>
.comments {
display: flex;
flex-direction: column;
width: 100%;
gap: 0.5rem;
}
/* Lifted over the reply rail for the same reason `.reply-box` is: the rail
starts half a gap above the replies so it reaches back to this card, and
would otherwise be drawn across its bottom edge. */
.top-level-comment {
position: relative;
z-index: 1;
background-color: var(--color-surface-canvas);
border: 1px solid var(--color-border-subtle);
border-radius: var(--border-radius-sm);
}
/* Inside a diff the surrounding surface is already the canvas, so a comment on
it needs the next step up to read as sitting over the code rather than
blending into it. */
.comments.inline .top-level-comment,
.comments.inline .reply-box,
.comments.inline .reply-form-box {
background-color: var(--color-surface-subtle);
}
/* That surface is what an icon button fills with on hover, so on these cards
the hover would be invisible; take it one step further instead. */
.comments.inline :global(.global-icon-button:hover),
.comments.inline :global(.global-icon-button:focus-visible) {
background-color: var(--color-surface-strong);
}
.replies-wrapper {
position: relative;
margin-left: 3rem;
}
/* The same indent the activity timeline sets for its threads; the 3rem default
is only ever seen where neither of them applies. */
.comments.inline .replies-wrapper {
margin-left: 1.5rem;
}
.replies-wrapper::before,
.replies-wrapper::after {
content: "";
position: absolute;
top: -0.5rem;
height: calc(100% + 0.5rem);
width: 1px;
background-color: var(--color-border-subtle);
}
.replies-wrapper::before {
left: -1.75rem;
}
.replies-wrapper::after {
left: 1.25rem;
}
/* The outer rail continues the surrounding activity timeline down to the
top-level composer. Inline code threads have no timeline around them, so
it would end in mid-air; only the reply indent line is drawn there. */
.replies-wrapper.inline::before {
content: none;
}
.replies-list {
display: flex;
flex-direction: column;
gap: 0.5rem;
}
.reply-box,
.reply-form-box {
position: relative;
z-index: 1;
border: 1px solid var(--color-border-subtle);
border-radius: var(--border-radius-sm);
background-color: var(--color-surface-canvas);
}
.reply-form-box {
padding: 1rem;
}
/* Says which comment you arrived at after jumping to one. Drawn as a ring
outside the card's own border so it adds no height — the diff measures these
boxes to lay itself out — and faded rather than switched off, so the eye
follows it going as well as coming. */
.top-level-comment,
.reply-box {
transition: box-shadow 0.4s ease-out;
}
.top-level-comment.highlighted,
.reply-box.highlighted {
box-shadow: 0 0 0 2px var(--color-border-brand);
}
</style>
{#snippet repliesSnippet()}
<div class="replies-list">
{#each replies as reply}
<div
class="reply-box"
class:highlighted={highlightedCommentId === reply.id}>
<CommentComponent
disallowEmptyBody
{rid}
{currentUserNid}
lastEdit={reply.edits.length > 1 ? reply.edits.at(-1) : undefined}
id={reply.id}
author={reply.author}
caption="replied"
resolved={reply.resolved}
resolvedCaption={resolvedCaption(reply.id)}
reactions={reply.reactions}
timestamp={reply.edits[0].timestamp}
body={reply.edits.slice(-1)[0].body}
editComment={canModifyComment(reply.author.did) &&
editComment?.bind(null, reply.id)}
reactOnComment={reactOnComment?.bind(null, reply.id)}
deleteComment={canModifyComment(reply.author.did)
? deleteComment?.bind(null, reply.id)
: undefined} />
</div>
{/each}
{#if createReply && showReplyForm}
<div class="reply-form-box" id={`reply-${root.id}`}>
<ExtendedTextarea
inline
disallowEmptyBody
{submitInProgress}
{rid}
placeholder="Reply to comment"
submitCaption="Reply"
submitActiveVariant="secondary"
focus
close={() => (showReplyForm = false)}
submit={async ({ comment, embeds }) => {
try {
submitInProgress = true;
await createReply(comment, Array.from(embeds.values()), root.id);
} finally {
showReplyForm = false;
submitInProgress = false;
}
}} />
</div>
{/if}
</div>
{/snippet}
<div class="comments" class:inline>
<div
class="top-level-comment"
class:highlighted={highlightedCommentId === root.id}>
<CommentComponent
disallowEmptyBody
{rid}
{currentUserNid}
{draft}
{origin}
{hoverNote}
resolved={root.resolved}
resolvedCaption={resolvedCaption(root.id)}
id={root.id}
lastEdit={root.edits.length > 1 ? root.edits.at(-1) : undefined}
author={root.author}
reactions={root.reactions}
timestamp={root.edits.slice(-1)[0].timestamp}
body={root.edits.slice(-1)[0].body}
editComment={canModifyComment(root.author.did) &&
editComment?.bind(null, root.id)}
reactOnComment={reactOnComment?.bind(null, root.id)}
deleteComment={canModifyComment(root.author.did)
? deleteComment?.bind(null, root.id)
: undefined}>
{#snippet actions()}
{#if changeCommentStatus && canResolve}
<span
class="global-icon-button"
title={root.resolved ? "Mark as unresolved" : "Mark as resolved"}>
<!-- The counterpart to the `comment-checkmark` a resolved thread is
counted with, rather than that glyph again: in a button the
badge reads as the state it already is, not as undoing it. -->
<Icon
name={root.resolved ? "comment-cross" : "checkmark"}
onclick={() => changeCommentStatus(root.id, !root.resolved)} />
</span>
{/if}
{#if createReply}
<span class="global-icon-button" title="Reply">
<Icon name="reply" onclick={toggleReply} />
</span>
{/if}
{/snippet}
</CommentComponent>
</div>
{#if replies.length > 0 || (createReply && showReplyForm)}
<div class="replies-wrapper" class:inline>
{@render repliesSnippet()}
</div>
{/if}
</div>