From d78b63956af2b627d19d2d3ab0b3d24cae2da4cd Mon Sep 17 00:00:00 2001 From: Fintan Halpenny Date: Mon, 2 Sep 2024 13:25:11 +0100 Subject: [PATCH] surf: clippy base64 cleanup The `base64` dependency is only required with the `serde` feature. Move the import of `Engine` into the implentation sites. Signed-off-by: Fintan Halpenny X-Clacks-Overhead: GNU Terry Pratchett --- radicle-surf/src/blob.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/radicle-surf/src/blob.rs b/radicle-surf/src/blob.rs index 7403ed0..d8870f8 100644 --- a/radicle-surf/src/blob.rs +++ b/radicle-surf/src/blob.rs @@ -20,8 +20,8 @@ use std::ops::Deref; -use base64::Engine; use radicle_git_ext::Oid; + #[cfg(feature = "serde")] use serde::{ ser::{SerializeStruct as _, Serializer}, @@ -128,6 +128,8 @@ where where S: Serializer, { + use base64::Engine as _; + const FIELDS: usize = 4; let mut state = serializer.serialize_struct("Blob", FIELDS)?; state.serialize_field("id", &self.id)?; @@ -152,6 +154,8 @@ impl<'a> Serialize for BlobRef<'a> { where S: Serializer, { + use base64::Engine as _; + const FIELDS: usize = 3; let mut state = serializer.serialize_struct("BlobRef", FIELDS)?; state.serialize_field("id", &self.id())?;