mirror of
https://seed.radicle.dev/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5.git
synced 2026-11-21 18:40:39 +08:00
cli/patch/review: Obsoletion Warning
As discussed in: <https://radicle.zulipchat.com/#narrow/channel/369873-Support/topic/new.20to.20reviewing.20patches/with/533862639>
This commit is contained in:
committed by
Fintan Halpenny
parent
8dd17e2a60
commit
7b00bf2e3a
@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
- The option `rad self --nid` was deprecated in favor of `rad status --only nid`
|
||||
- `rad diff` was deprecated in favor of using `git diff`
|
||||
- `rad patch review --patch` and `rad patch review --delete` are made obsolete.
|
||||
This functionality never worked as intended, and may be removed before the
|
||||
next major release.
|
||||
|
||||
## New Features
|
||||
|
||||
|
||||
@@ -83,6 +83,7 @@ pub fn run(
|
||||
unified,
|
||||
hunk,
|
||||
} if by_hunk => {
|
||||
crate::warning::obsolete("rad patch review --patch");
|
||||
let mut opts = git::raw::DiffOptions::new();
|
||||
opts.patience(true)
|
||||
.minimal(true)
|
||||
@@ -124,6 +125,7 @@ pub fn run(
|
||||
}
|
||||
}
|
||||
Operation::Delete => {
|
||||
crate::warning::obsolete("rad patch review --delete");
|
||||
let name = git::refs::storage::draft::review(profile.id(), &patch_id);
|
||||
|
||||
match repository.backend.find_reference(&name) {
|
||||
|
||||
Reference in New Issue
Block a user