mirror of
https://seed.radicle.dev/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5.git
synced 2026-11-17 00:30:40 +08:00
The logic for computing canonical references conflated the semantics of annotated and lighweight tags, yielding confusing/wrong results. The main culprit was the call to `peel_to_commit` in `impl ReadRepository for Repository`, peeling tag objects away. To resolve this, we separate out quroum computation per object type: one implementation for commits, and one for tags. Also move move canonical error types and methods into their own module to have a cleaner file structure for the main logic. Capture the `BTreeMap<Oid, u8>` type into a `Votes` struct, with its own API. We were getting the objects from the repository twice – once in `Canonical::new` and once again in `ensure_commit_or_tag` – so the latter was removed. Use an `enum CanonicalObject` to specify which object types the canonical process supports. During `converges`, separate commits and tags, and ensure that we are only looking at objects of one type. Note, that Fintan think this is actually the *wrong* place to do it because we already filter the objects – so we should keep track of that information higher up the callstack. Co-authored-by: Fintan Halpenny <fintan.halpenny@gmail.com>
81 lines
3.3 KiB
Markdown
81 lines
3.3 KiB
Markdown
Let's see what happens if we try to push a head which diverges from the
|
|
canonical head.
|
|
|
|
First we add a second delegate, Bob, to our repo:
|
|
|
|
``` ~alice
|
|
$ rad id update --title "Add Bob" --description "" --delegate did:key:z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk --repo rad:z42hL2jL4XNk6K8oHQaSWfMgCL7ji -q
|
|
c036c0d89ce26aef3ad7da402157dba16b5163b4
|
|
```
|
|
|
|
Then, as Bob, we commit some code on top of the canonical head:
|
|
|
|
``` ~bob
|
|
$ rad sync --fetch
|
|
Fetching rad:z42hL2jL4XNk6K8oHQaSWfMgCL7ji from the network, found 1 potential seed(s).
|
|
✓ Target met: 1 seed(s)
|
|
🌱 Fetched from z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
|
|
$ rad inspect --delegates
|
|
did:key:z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi (alice)
|
|
did:key:z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk (bob)
|
|
$ git commit -m "Third commit" --allow-empty -q
|
|
$ git push rad
|
|
$ git branch -arv
|
|
alice@z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi/master f2de534 Second commit
|
|
rad/master 319a7dc Third commit
|
|
```
|
|
|
|
As Alice, we fetch that code, but commit on top of our own master, which is no
|
|
longer canonical, since Bob pushed a more recent commit, and the threshold is 1:
|
|
|
|
``` ~alice
|
|
$ rad remote add did:key:z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk --fetch --no-sync
|
|
✓ Remote bob@z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk added
|
|
✓ Remote-tracking branch bob@z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk/master created for z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk
|
|
$ git branch -arv
|
|
bob@z6Mkt67GdsW7715MEfRuP4pSZxJRJh6kj6Y48WRqVv4N1tRk/master 319a7dc Third commit
|
|
rad/master f2de534 Second commit
|
|
$ git commit -m "Third commit by Alice" --allow-empty -q
|
|
```
|
|
|
|
If we try to push now, we get an error with a hint, telling us that we need to
|
|
integrate Bob's changes before pushing ours:
|
|
|
|
``` ~alice (stderr) (fail) RAD_HINT=1
|
|
$ git push rad
|
|
hint: you are attempting to push a commit that would cause your upstream to diverge from the canonical reference refs/heads/master
|
|
hint: to integrate the remote changes, run `git pull --rebase` and try again
|
|
error: refusing to update canonical reference to commit that is not a descendant of current canonical head
|
|
error: failed to push some refs to 'rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi'
|
|
```
|
|
|
|
We do that, and notice that we're now able to push our code:
|
|
|
|
``` ~alice
|
|
$ git pull --rebase
|
|
$ git log --oneline
|
|
f6cff86 Third commit by Alice
|
|
319a7dc Third commit
|
|
f2de534 Second commit
|
|
08c788d Initial commit
|
|
```
|
|
``` ~alice RAD_SOCKET=/dev/null (stderr)
|
|
$ git push rad
|
|
✓ Canonical reference refs/heads/master updated to target commit f6cff86594495e9beccfeda7c20173e55c1dd9fc
|
|
To rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
|
|
f2de534..f6cff86 master -> master
|
|
```
|
|
|
|
One thing of note is that we can revert to an older commit as long as we are
|
|
still ahead of the other delegates.
|
|
|
|
``` ~alice
|
|
$ git reset --hard HEAD^ -q
|
|
```
|
|
``` ~alice RAD_SOCKET=/dev/null (stderr)
|
|
$ git push -f
|
|
✓ Canonical reference refs/heads/master updated to target commit 319a7dc3b195368ded4b099f8c90bbb80addccd3
|
|
To rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
|
|
+ f6cff86...319a7dc master -> master (forced update)
|
|
```
|