Commit Graph
473 Commits
Author SHA1 Message Date
Lars Wirzenius 84cfab01de feat: lower log level for various messages
Log level info should not be full of irrelevancies for node operators.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-25 10:18:20 +02:00
Lars Wirzenius 67c215c9d8 fix: show branch name in push events in HTML reports
We used to parse the ref name to find out the branch name, when
creating a trigger message. The CI events now do that for us. This
meant that parsing the branch name failed, and resulted in the empty
string.

Fix this by using already-parsed branch name from the CI event instead
of trying to parse it again.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-22 12:56:23 +02:00
Lars Wirzenius 70f1ba7de5 chore: prepare release 0.9.0
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-21 10:19:56 +02:00
Lars Wirzenius 54c3459aa4 feat: add repository alias to event queue
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-20 12:41:41 +02:00
Lars Wirzenius b707c812df feat: add count of recent failures to front page
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-20 12:17:54 +02:00
Lars Wirzenius d5f6520486 feat: add run counts for all repositories together to report
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-20 11:36:39 +02:00
Lars Wirzenius 331caf78ff feat: add per-repository run count (total, failed) to report
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-20 11:32:57 +02:00
Lars Wirzenius b8027442ca fix: add a time stamp to RSS feed items
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-14 07:11:37 +02:00
Lars Wirzenius d7bccbfc0b fix: don't run tidy in subplot
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 18:13:21 +02:00
Lars Wirzenius 4caab2118c feat: generate RSS feeds for all, failed CI runs
This is primarily a stop-gap measure so I can have some notification
of CI runs, without having to manually check the report page. It may
also be useful for other people, who do not use Radicle themselves,
but are interested in CI runs on Radicle nodes.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 18:06:19 +02:00
Lars Wirzenius dc61d2bbbb doc: reorder sections so that the more general case comes first
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 09:47:26 +02:00
Lars Wirzenius 92cbd0c730 doc: add goals to CI architecture doc
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 09:47:26 +02:00
Lars Wirzenius b199175ac0 doc: generate sample adapter messages with code
This removes the need to update them manually. Now they'll always be
up to date.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 09:47:26 +02:00
Lars Wirzenius 7ddb877a15 doc: format with Subplot, improve text
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 09:47:22 +02:00
Lars Wirzenius 43c076c22e feat: generate sample adapter messages with cibtool
This is meant only for generating documentation, but might be useful
for others.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-13 09:45:29 +02:00
Lars Wirzenius c377b05a97 test: add step to install an adapter
This is simpler to understand, for most readers of the subplot, than
installing a file and adjusting its Unix permissions with chmod.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 16:50:19 +02:00
Lars Wirzenius d76efe4007 test: have just one step to install all of CI broker
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 16:04:59 +02:00
Lars Wirzenius 842ce74f02 test: add new step "then stdout is empty"
This is a little clearer than 'then stdout is exactly ""'

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 15:34:32 +02:00
Lars Wirzenius 768b966890 fix: drop non-logging stderr output outside tests
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 15:11:37 +02:00
Lars Wirzenius 1e1587e820 feat: make sensitive_env optional in the configuration file
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 14:48:50 +02:00
Lars Wirzenius f3b83c30d8 feat: drop timeoutcmd.rs log messages to trace level
Also move them to logger.rs.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 09:19:45 +02:00
Lars Wirzenius 5aea92df7b feat: make it harder to leak sensitive environment variables
Add a new type for sensitive values, for `sensitive_envs`.

The CI broker can define sensitive environment variables for each
adapter, in the `sensitive_envs` field in the configuration file. The
idea is the this can be used to configure, say, API keys that the CI
run needs. To avoid them leaking accidentally, the code tries to
prevent the sensitive value from being printed. However, there have
been case where this has failed to be done correctly. The problem is
that each place where the `Config` value is used needs to be careful
to avoid leaking sensitive data.

The new type provides the protection in a more concentrated location.
The value can be created via serde de-serialization, but can't be
printed using normal formatting, debug formatting, or serde
serialization. This doesn't protect against the sensitive value
leaking via a core dump, or direct memory reading.

None of this makes it a good idea to use environment variables to
convey sensitive values. They're a bad idea and one should find a
better way to achieve the same thing. However, as long as the CI
broker provides the `sensitive_envs` configuration variable the least
it can do is try to make it hard to accidentally leak the values.

This is not a breaking change.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-12 08:17:43 +02:00
Lars Wirzenius 26d55f0604 feat: add link to front page to the per-repository report page
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-08 14:53:24 +02:00
Lars Wirzenius 10b6e6da9e test: use more recent releases for upgrade testing
Each additional version makes the upgrade test take longer, and we
only really need to care about recent releases, I think.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-08 13:49:51 +02:00
Lars Wirzenius 869b451728 chore: prepare release 0.8.0
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-08 10:17:11 +02:00
Lars Wirzenius 55e1e7dba5 feat: add optional max_run_time field to configuration file
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-11-06 18:52:30 +02:00
Lars Wirzenius 30435e2001 feat: use new timeout-command module to execute adapter
The time out is hard coded to be 1000 seconds in this commit. Making
it configurable will come later.
2024-11-06 17:34:17 +02:00
Lars Wirzenius 0e78c6a8d8 feat: add a "cibtool timeout" subcommand
This lets us use the previously added code to run a sub-process with a
time limit. This is only meant for experimentation.
2024-11-06 16:30:42 +02:00
Lars Wirzenius 68f392dd78 feat: add a module to run a sub-process with a time limit
Also, capture its stdout and stderr.
2024-11-06 16:23:51 +02:00
Lars Wirzenius 0f90e97a3e feat: notify page generation about changes to runs more often
Change src/adapter.rs to send notification via the run notification
channel when the adapter is spawned, and when the adapter sends a
"triggered" message.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-21 16:19:09 +03:00
Lars Wirzenius 10ee855966 refactor: store timeout in receiver, separate event/run senders
Add new NotificationChannel constructors, for different kinds of
channels. Store the receive timeout in the receiver; it depends on
kind of channel.

Also add methods to send and receive notifications to senders and
receivers. This hides the std::sync::mpsc machinery better, and makes
the types easier to use.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-21 16:11:12 +03:00
Lars Wirzenius d537fd39d1 feat: filter on originating node for an event
Add the `Node(nid)` event filter.

Add the `from_node` field to the `BranchDeleted` event so that it too
can be filtered based on node.

Adjust debug logging for event filtering so that it reports the
filtering decision.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-21 14:07:11 +03:00
Lars Wirzenius caf839b592 feat: add cibtool remove event option --all to empty event queue
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-21 11:42:04 +03:00
Lars Wirzenius 3282510629 fix: make sure cib doesn't use node it shouldn't
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-18 12:26:43 +03:00
Lars Wirzenius 35acece8d0 fix: spelling of reference to RequestBuilder
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-18 12:26:30 +03:00
Lars Wirzenius 98665ff4ac docs: format and publish user guide in CI
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-18 10:17:17 +03:00
Lars Wirzenius fa61cdda23 tests: hide log messages from output in successful tests
This was unexpectedly difficult to figure out, but I got there.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-18 09:29:01 +03:00
Lars Wirzenius 513eb2c568 feat: on the front status page, tell result run if known
Previously we just said "finished", now we say "finished, success" or
the like.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-16 11:13:15 +03:00
Lars Wirzenius 535b159290 chore: update release 0.7.0
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-14 11:11:07 +03:00
Lars Wirzenius 938f627443 feat: cibtool event add --base value is not rev-parsed
This allows a value of, say, HEAD, which is convenient.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-11 08:58:21 +03:00
Lars Wirzenius a0122d8842 feat! mark CI event enum type as non-exhaustive
This should make it easier to evolve the enums as it forces users to
handle unknown variants explicitly.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-11 08:41:50 +03:00
Lars Wirzenius 320c426904 refactor: make BrokerError::NotTrigger not be so large
It's awkward if enum variants have wildly different sizes. Change
BrokerError::NotTrigger to store the Request value in a Box, so that
it's not in the enum directly. This makes all variants about the same
size, and thus the decorators that allow the
clippy::large_enum_variant can be dropped.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 18:44:11 +03:00
Lars Wirzenius 145e061aff feat: make CI events versioned
This will help us avoid breaking changes in the future, when CI events
need to be modified, and CI broker instances need to cope with the
event queues in their databases.

Previously we had

    enum CiEvent {
        BranchCreated { ... },
        BranchUpdatee { ... },
        ....
    }

Change that to:

    enum CiEvent {
        V1(CiEventV1),
    }

    enum CiEventV1 {
        BranchCreated { ... },
        BranchUpdatee { ... },
        ....
    }

This will allow us to add new version variants to CiEvent, without
losing access to the already enqueued V1 events.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 18:11:16 +03:00
Lars Wirzenius 5e813f739e fix: doc comment
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 13:03:27 +03:00
Lars Wirzenius 441a9db7dc fix: spurious plural in log message
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 12:56:48 +03:00
Lars Wirzenius 85efaa10d1 feat: allow user to set minimum log level for cib
Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 12:35:51 +03:00
Lars Wirzenius 5b5ba29e9d feat: log event queue length at log level "trace"
This reduces log spam.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-10 09:16:44 +03:00
Lars Wirzenius c8d6c0f53f fix: adjust log level for error message
Log the "CI broker ends in unrecoverable error" message at the
error level. instead of info.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-09 10:29:23 +03:00
Lars Wirzenius 47064e5785 chore: deny clippy warning about unwrap being used
An unwrap (or unwrap_err, or their expect variants) can result in run
time panics: unwrapping an Option that is None can't return a useful
result, so it panics. Similar for a Result. I've previously tried to
grep for uses of unwrap, but the clippy warning is much more precise.

Add "deny(clippy::unwrap_used)" to the top of src/lib.rs, so it
affects the whole crate. Then fix any places where unwrap is used.

It's OK to use unwrap in tests: if the value is expected, but isn't
there, the test should fail, and panic is a fine way to fail the test.

Everywhere else it's better to make sure unwrap can't fail, and if it
can, return a Result and have the caller handle that.

Signed-off-by: Lars Wirzenius <liw@liw.fi>
2024-10-09 10:16:41 +03:00
Lars Wirzenius a9fea0fdbe Merge branch 'patch/bc2cc00' 2024-10-09 09:32:13 +03:00