This is the most rudimentary requirement. It does not verify they get
updated as the CI broker continues running and doing things, as that's
a little difficult to arrange a test for.
This revealed a problem in how the `cib process-events` threads work
together, so fix that too. Changed the page updater thread to output
the HTML report and JSON status file at least once, even if there were
not events to process. In addition, the event processing thread uses a
timeout to receive notification of new events, so that it doesn't get
stuck, if there aren't any events coming from the node control socket.
Added some logging to make it easier to debug these things in the
future.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Previously all subcommands for cibtool where in one file,
src/bin/cibtool.rs. That grew rather unwieldy and tiresome to
navigate. Split that into a module cibtoolcmd, with one sub-module per
top level subcommand for the leaf subcommands: the ones that do no
have subcommands themselves. Keep the rest of the subcommand structure
in cibtool.rs, so that it's easier to manage the subcommand structure
in one place.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Add stakeholder groups and change all scenarios to use those.
This is an initial set of stakeholders, to be built upon when the CI
broker starts maturing.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Make the "cibtool run add" options to set the state of a CI run be
more logical. There are now four:
* --triggered
* --running
* --success
* --failure
That is, drop the --running option. This allows the clap configuration
to specify that one of those four is required. I could not find a way
to specify that if --running was present, one of --success and
--failure was required, but that's OK: the --running option didn't
actually help to make things easier for the user.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Event adding process notifies event processing thread that there are
new events, and the event processing thread notifies the report page
generation thread that a new run has finished. In addition, the
reporting thread reports after a while whether there are any new runs
or not, so that the page time stamp gets updated.
Also drop some now-unused code.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
This will be useful for threads to notify each other that they have
work to do. The notification does not carry any information, such as
an event or a run, that goes via the database, for robustness and
simplicity.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Add a unique, immutable broker run ID to each run, in addition to the
adapter run ID that may not always be available, and is not guaranteed
to be unique.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
The trigger message given to the CI adapter to start a CI run must
have a list of commits. This requires the "ref changed" event to have
a base commit. The commits after the base commit to the tip commit in
the event become the list of commits in the trigger message.
"cibtool trigger" is given the tip commit with the "--commit" option.
Change it to use a parent commit of that as the base commit, or if
there is no parent commit (i.e., there is only the one commit in the
repository), the commit itself.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Change Request::commit to not panic if the push or patch data has no
commits, or if the request is neither push nor patch. Instead, return
an appropriate error. A panic message isn't very helpful to users;
errors can have helpful messages.
This changes the method signature of an exported method and that is a
breaking change.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
Change the tests to look more like production code. In addition, have
fewer places where .expect is used, to make it easier to find them by
a simple grep.
Signed-off-by: Lars Wirzenius <liw@liw.fi>
This means we do not panic if the locking fails. Instead we return an
error that will hopefully be logged and thus visible to the user in a
way that is easier to deal with than a panic
Signed-off-by: Lars Wirzenius <liw@liw.fi>