mirror of
https://seed.radicle.dev/rad:z4D5UCArafTzTQpDZNQRuqswh3ury.git
synced 2026-10-18 19:10:45 +08:00
Drop redundant steps from the checks
svelte-check already type-checks what tsc did, clippy already runs cargo check, and radicle-tauri has no doc tests. Linting all targets also covers test code, which cargo test builds but never lints.
This commit is contained in:
@@ -31,7 +31,7 @@ npm run start:http # Vite dev server backed by test-http-api (no Tauri runt
|
||||
Set `VITE_LOG_INVOKE_TIMINGS=true` to log each command's duration
|
||||
(`[invoke] <command> <ms>ms`) to the browser console. It is off by default.
|
||||
|
||||
### Checks and linting (tsc, svelte-check, eslint, prettier)
|
||||
### Checks and linting (svelte-check, eslint, prettier)
|
||||
|
||||
```sh
|
||||
npm run check
|
||||
@@ -86,7 +86,7 @@ SKIP_FIXTURE_CREATION=true npm run test:e2e
|
||||
### Rust backend (`crates/`)
|
||||
|
||||
```sh
|
||||
scripts/check-rs # cargo fmt --check, clippy --workspace, check, test
|
||||
scripts/check-rs # cargo fmt --check, clippy on all targets, test
|
||||
```
|
||||
|
||||
### Regenerate TypeScript bindings
|
||||
@@ -124,7 +124,7 @@ at the first failure. It writes the full output, with each step's duration
|
||||
and exit code, to `tests/tmp/check-ci.log`:
|
||||
|
||||
```sh
|
||||
npm run check # tsc, svelte-check, eslint, prettier,
|
||||
npm run check # svelte-check, eslint, prettier,
|
||||
# cargo fmt, cargo clippy, cargo test
|
||||
npm run test:unit
|
||||
scripts/install-binaries # skipped when already installed
|
||||
|
||||
@@ -9,6 +9,7 @@ publish = false
|
||||
[lib]
|
||||
name = "app_lib"
|
||||
crate-type = ["staticlib", "cdylib", "lib"]
|
||||
doctest = false
|
||||
|
||||
[build-dependencies]
|
||||
tauri-build = { version = "2.6.1", features = ["isolation"] }
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
#!/bin/sh
|
||||
set -e
|
||||
|
||||
npx tsc --noEmit
|
||||
# svelte-check also type-checks the .ts files in tsconfig.json, like tsc would.
|
||||
npx svelte-check --tsconfig tsconfig.json --fail-on-warnings --compiler-warnings options_missing_custom_element:ignore
|
||||
npx eslint --cache --cache-location node_modules/.cache/eslint --max-warnings 0 .
|
||||
npx prettier "**/*.@(ts|js|svelte|json|css|html|yml)" "!crates/**/*" --ignore-path .gitignore --check --cache
|
||||
|
||||
+1
-2
@@ -4,6 +4,5 @@ set -e
|
||||
mkdir -p "$(dirname "$0")/../build"
|
||||
|
||||
cargo fmt --check
|
||||
cargo clippy --workspace -- -Dwarnings
|
||||
cargo check --workspace
|
||||
cargo clippy --workspace --all-targets -- -Dwarnings
|
||||
cargo test --workspace
|
||||
|
||||
Reference in New Issue
Block a user