mirror of
https://seed.radicle.dev/rad:z4V1sjrXqjvFdnCUbxPFqd5p4DtH5.git
synced 2026-11-02 18:20:29 +08:00
Allow verdict and summary changes in draft reviews
While a patch review is still in draft mode we should allow it to be changed to no verdict or an empty summary. The validation logic being taken care of by the `Publish draft` button.
This commit is contained in:
@@ -387,6 +387,7 @@
|
||||
{#if !!roles.isDelegateOrAuthor( config.publicKey, repo.delegates.map(delegate => delegate.did), review.author.did, )}
|
||||
<VerdictButton
|
||||
selectedVerdict={verdict}
|
||||
draft={"draft" in review}
|
||||
summaryMissing={review.summary === undefined ||
|
||||
review.summary.trim() === ""}
|
||||
onSelect={async newVerdict => {
|
||||
@@ -435,7 +436,7 @@
|
||||
<CommentComponent
|
||||
disableAttachments
|
||||
rid={repo.rid}
|
||||
disallowEmptyBody={review.verdict === undefined}
|
||||
disallowEmptyBody={!("draft" in review) && review.verdict === undefined}
|
||||
emptyBodyTooltip="Summary is mandatory when verdict is None"
|
||||
styleWidth="100%"
|
||||
caption={"draft" in review ? "draft review" : "published review"}
|
||||
|
||||
@@ -15,11 +15,12 @@
|
||||
|
||||
interface Props {
|
||||
onSelect: (selectedVerdict: Review["verdict"]) => Promise<void>;
|
||||
draft: boolean;
|
||||
summaryMissing: boolean;
|
||||
selectedVerdict: Review["verdict"];
|
||||
}
|
||||
|
||||
const { onSelect, summaryMissing, selectedVerdict }: Props = $props();
|
||||
const { onSelect, draft, summaryMissing, selectedVerdict }: Props = $props();
|
||||
|
||||
let popoverExpanded: boolean = $state(false);
|
||||
</script>
|
||||
@@ -69,7 +70,9 @@
|
||||
title={verdict === undefined && summaryMissing
|
||||
? "Set a summary to select verdict None"
|
||||
: undefined}
|
||||
disabled={verdict === undefined && summaryMissing}
|
||||
disabled={draft === false &&
|
||||
verdict === undefined &&
|
||||
summaryMissing}
|
||||
selected={selectedVerdict === verdict}
|
||||
onclick={async () => {
|
||||
await onSelect(verdict);
|
||||
|
||||
Reference in New Issue
Block a user