Renaming confusing method startPeer to createPeer

The name was confusing because the function does not actually start any
services.
This commit is contained in:
Thomas Scholtes
2023-12-11 12:13:51 +01:00
parent f2eb867d1f
commit 7d61539d95
7 changed files with 13 additions and 13 deletions
+1 -1
View File
@@ -16,7 +16,7 @@ describe("session", async () => {
Path.join(tmpDir, "peerManager.log"),
).setMaxListeners(16),
});
const peer = await peerManager.startPeer({
const peer = await peerManager.createPeer({
name: "session",
gitOptions: gitOptions["alice"],
});
+1 -1
View File
@@ -20,7 +20,7 @@ export const testFixture = test.extend<TestFixtures>({
Path.join(tmpDir, "peerManager.log"),
).setMaxListeners(16),
});
const peer = await peerManager.startPeer({
const peer = await peerManager.createPeer({
name: "palm",
gitOptions: gitOptions["alice"],
});
+1 -1
View File
@@ -7,7 +7,7 @@ import {
} from "@tests/support/fixtures.js";
test("node metadata", async ({ page, peerManager }) => {
const peer = await peerManager.startPeer({
const peer = await peerManager.createPeer({
name: "node-metadata-peer",
});
await peer.startHttpd();
+1 -1
View File
@@ -126,7 +126,7 @@ test("relative timestamps", async ({ page }) => {
});
test("pushing changes while viewing history", async ({ page, peerManager }) => {
const alice = await peerManager.startPeer({
const alice = await peerManager.createPeer({
name: "alice",
gitOptions: gitOptions["alice"],
});
+3 -3
View File
@@ -159,7 +159,7 @@ export const test = base.extend<{
},
authenticatedPeer: async ({ page, peerManager }, use) => {
const peer = await peerManager.startPeer({
const peer = await peerManager.createPeer({
name: "httpd",
gitOptions: gitOptions["bob"],
});
@@ -288,12 +288,12 @@ export async function createSourceBrowsingFixture(
sourceBrowsingDir,
]);
const rid = sourceBrowsingRid;
const alice = await peerManager.startPeer({
const alice = await peerManager.createPeer({
name: "alice",
gitOptions: gitOptions["alice"],
});
const aliceProjectPath = Path.join(alice.checkoutPath, "source-browsing");
const bob = await peerManager.startPeer({
const bob = await peerManager.createPeer({
name: "bob",
gitOptions: gitOptions["bob"],
});
+1 -1
View File
@@ -45,7 +45,7 @@ export default async function globalSetup(): Promise<() => void> {
.setMaxListeners(16),
});
const palm = await peerManager.startPeer({
const palm = await peerManager.createPeer({
name: "palm",
gitOptions: gitOptions["alice"],
});
+5 -5
View File
@@ -72,7 +72,7 @@ interface PeerManagerParams {
}
export interface PeerManager {
startPeer(params: {
createPeer(params: {
name: string;
gitOptions?: Record<string, string>;
}): Promise<RadiclePeer>;
@@ -98,17 +98,17 @@ export async function createPeerManager(createParams: {
outputLog = outputLogFile.createWriteStream();
}
const nodes: RadiclePeer[] = [];
const peers: RadiclePeer[] = [];
return {
async startPeer(params) {
async createPeer(params) {
const peer = await RadiclePeer.create({
dataPath: createParams.dataDir,
name: params.name,
gitOptions: params.gitOptions,
node: generateNode(nodes.length + 1),
node: generateNode(peers.length + 1),
outputLog,
});
nodes.push(peer);
peers.push(peer);
return peer;
},