Don't push empty project description to page title

This commit is contained in:
Sebastian Martinez
2024-01-25 16:25:47 +00:00
committed by Rūdolfs Ošiņš
parent 27dcde41b0
commit d50f0ca434
2 changed files with 28 additions and 1 deletions
+3 -1
View File
@@ -943,7 +943,9 @@ export function projectTitle(loadedRoute: ProjectLoadedRoute) {
if (loadedRoute.resource === "project.source") {
title.push(loadedRoute.params.project.name);
title.push(loadedRoute.params.project.description);
if (loadedRoute.params.project.description.length > 0) {
title.push(loadedRoute.params.project.description);
}
} else if (loadedRoute.resource === "project.commit") {
title.push(loadedRoute.params.commit.commit.summary);
title.push("commit");
+25
View File
@@ -6,6 +6,7 @@ import {
sourceBrowsingUrl,
test,
} from "@tests/support/fixtures.js";
import { createProject } from "@tests/support/project";
import {
expectBackAndForwardNavigationWorks,
expectUrlPersistsReload,
@@ -112,6 +113,30 @@ test.describe("project page navigation", () => {
await expectUrlPersistsReload(page);
});
test("page title", async ({ page }) => {
await page.goto(sourceBrowsingUrl, {
waitUntil: "networkidle",
});
const title = await page.title();
expect(title).toBe(
"source-browsing · Git repository for source browsing tests",
);
});
test("page title on project with empty description", async ({
page,
authenticatedPeer,
}) => {
const { rid } = await createProject(authenticatedPeer, {
name: "ProjectWithNoDescription",
});
await page.goto(authenticatedPeer.ridUrl(rid), {
waitUntil: "networkidle",
});
const title = await page.title();
expect(title).toBe("ProjectWithNoDescription");
});
test("navigate project paths with an explicitly selected peer", async ({
page,
}) => {