It's difficult to debug errors that mention a resource not being
found, but not which resource was not found.
Return the error message for not found variants.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
The fetch V2 improvements introduced a `UserInfo` type that is used to
set the Git config's name and email when cloning a repository. This
`UserInfo` can also be used when creating a new `Repository`.
The `Storage` type now takes a `UserInfo` so that it can be passed to
`Repository::create`, for creating a new repository.
For testing, this requires adding a new `fixtures::user` so that
testing `Storage` instances can be easily constructed.
It also means that the `radicle-cli` tests all changed with new SHAs
since the name and email are used as part of the hashing input.
N.b. the order of the timelines while testing the identity cob
changed. It's not clear why that is.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
- use key icon in connect/authenticate modal
- use person without hat for contributors
- use +- icon for diffs
- use color to distinguish between track/tracking states
We elminitate the element with the “button” role that wrapped the
Popover toggle slot. The element rendered into the slot is in all cases
already a button. This prevents issues where `getByRole("button")` finds
_two_ buttons for popover toggles.
We take the opportunity to simplify the popover toggling by making the
slot responsible for the toggle. This has a couple of advantages:
* We don’t need a `disabled` property for Popover. This is handled by
the button. (This fixes a bug we did not disable the PeerSelector
Popover properly.)
* The popover is opened on key events
In the future this also gives us more flexibility in determining how to
toggle the Popover.
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Instead of sending a request for each label and assignee change on a
existing issue or patch, we should just do that for the new form,
where we wait for the confirmation for the final creation of the issue or patch.
Instead of showing the node id with a clipboard that copies a possible
wrong port number, this commit adds the externalAddresses config to the
node detail view, so node operators can define which externalAddresses
should show up.
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
Co-authored-by: Rūdolfs Ošiņš <rudolfs@osins.org>
The `identity_doc_at` and `identity_doc` methods on `ReadRepository`
returned the unverified identity document. Every usage of these
methods would always verify the document after.
Simplify the code by calling verified in the methods and directly return the
verified identity document.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
Make the validation logic customisable by extracting it out into a
separate trait that can be defined by other crates.
The Repository validation logic stays the same.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
Currently we only handle data Uris, but when a user sends a comment that
has a existing git Oid, due to editing a comment we also need to handle
this case.
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
Also does some refactoring for `action`, `editable` and other variables
we were using which weren't very clear
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
We want the textarea to grow when a user writes longer text. This also
fixes the `resizable` property, which when `true` allows the user to
resize the textarea with their mouse.
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>