Commit Graph
2316 Commits
Author SHA1 Message Date
Sebastian Martinez 580ccbcf1a Invert markdown plain buttons in Blob component
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-16 11:17:13 +02:00
Rūdolfs Ošiņšanddnlklmn d914710396 Implement new design
Co-authored-by: dnlklmn <pelicansinberlin@gmail.com>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-10-13 18:05:19 +02:00
cloudhead 472f38bacf cob: Introduce xyz.radicle.id COB
Introduces a new COB type to store repository identity documents.

The reason for this change is to:

1. Simplify the code, as the identity document logic resembled a COB,
   yet it had custom logic. This allows existing COB code to be used for
   identities.
2. Make identity document update logic more flexible, since COB actions
   can be added in the future.
3. Re-purpose existing tools around COBs to work on identities, eg. `rad
   cob`.
4. Unify the concept of an identity change proposal, with regular identity
   changes. This means we can remove the `id.proposal` COB in favor of
   using the `id` COB itself.

Notes
-----

* Each repository has one Identity COB.
* The `Proposal` COB has been repurposed into the `Identity` COB.
* Identity documents are stored as *embeds* inside the Identity COB
  actions.
* The action that contains new document versions is called `revision`,
  just like the Patches COB.
* The namespaced `rad/id` ref is a symbolic reference to that Identity
  COB.
* The canonical `rad/id` ref is a direct reference to the commit in the
  Identity COB that contains the latest *accepted* revision of the
  document.
* All commands for managing identities have been folded into `rad id`.
  Hence `rad delegate` and `rad edit` are removed.
* The concept of "rebasing" an identity document is gone.
* The `rad id` output has been updated to match the style of other
  commands.
* When a revision has enough signatures, it is automatically adopted as
  the current identity, there is no longer the need for a "commit"
  action.
* When an identity revision is proposed, and the current identity has a
  threshold of `1`, that identity is automatically accepted due to the
  above point.
* The idea of "verifying a peer's identity branch" no longer applies, as
  COBs cannot be verified one history at a time.
* Since the root commit of the Identity COB does not have a "Resource"
  to point to (it would have to point to itself, which is impossible),
  we've made the resource id optional for COBs.
2023-10-12 17:32:33 +02:00
Sebastian Martinez c5c609167e Update deps
Updates transitive dependencies

Fixes zod vulnerability
> Zod version 3.22.2 allows an attacker to perform a denial of service while validating emails.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-12 09:22:31 +02:00
Sebastian Martinez 120c109d0d Update radicle-surf to v0.17
This commit introduces the `FileStats` struct, that adds the insertions
and deletions for each file to `DiffContent`.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-11 14:29:34 +02:00
Sebastian Martinez 0dd85ca24a httpd: Add configuration to /node endpoint
Adds the "config" key containing node configuration.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-11 13:51:38 +02:00
Sebastian Martinez c97f693e1a httpd: Add missing COB actions
Handles missing issue and patch actions. Adds embeds to patch comments.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-11 13:36:48 +02:00
Sebastian Martinez b12a9495cb Navigate to LoadError when node view isn't able to load
This can have multiple reasons, interface has added a new property but
httpds haven't updated yet.
Other issues with some specific endpoints that return a 500 and we can't
load it.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-06 14:18:48 +02:00
Sebastian Martinez 288f55da76 Add syntax highlighting to patch and commit changesets
- This commit doesn't change the way syntax highlighting is done.
- But due to changes in `radicle-httpd` we can highlight the entire
  files of a changeset, and then replace the plain text lines with
  highlighted ones.
- Also highlights only the files currently visible of a changeset.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-05 13:55:00 +02:00
Sebastian Martinez 7f51ba8488 httpd: Return entire files from commit handler
Used for syntax highlighting.

Also improves the handling of multiple parent commits, by adding all of
them.
2023-10-03 12:19:18 +02:00
Sebastian Martinez 36f4cb4961 httpd: Increase body size limit for /projects/*
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-03 11:59:11 +02:00
Sebastian Martinez 8eaf39e6ae Wrap links or similar in Comment component
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-02 12:46:28 +02:00
Sebastian Martinez aa2ce409fb Update GitHub CI
Due to us moving to Radicle, we need to implement the following changes.

- We don't need the CI to run on pull_requests anymore.
- We want the CI to run on any push.
- For visual tests we don't want to update any comments and just fail
  the test and upload the artifacts for checking.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-10-02 11:23:09 +02:00
Sebastian Martinez bea8af8497 Update marked-katex-extension
This fixes the issue with rendering code blocks without a blank line
between text and the start of a codeblock that starts with a `$`

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-28 08:57:19 +02:00
Sebastian Martinez ed5a0b382b Update heartwood
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-27 16:40:49 +02:00
Sebastian Martinez 1ef0f9dfd1 Add issue embeds
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-27 16:40:49 +02:00
cloudhead cd4e9870bf cli: Update to radicle-surf 0.16 2023-09-27 15:54:16 +02:00
Sebastian Martinez 2864a0311b Removing the Safari requirement
Due to marked-katex not using negative look behind regex anymore.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-27 07:56:26 +02:00
Sebastian Martinez 9f68848bc0 Update dependencies
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-27 07:56:26 +02:00
Sebastian Martinez da7258d2bf httpd: Improve data-uri support
We were just using `strip_prefix` with a hardcoded value, which wasn't
able to adjust to URIs that start with `data:image/png` or other content
and types.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-26 17:33:06 +02:00
Sebastian Martinez 6e17d98d96 Reduce test flakiness on global hotkeys
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-26 09:43:09 +02:00
Sebastian Martinez bd6ba784b3 Improve binary detection
libgit2 optimizes around not loading the content, when there's no
content callbacks configured.

So we aren't able to get a clear answer from radicle-surf if a file in a
diff is a binary or not.

A simple way without doing additional API requests is to check if the
file type is a executable and if there are no hunks (since we don't get
any deltas in binaries), this is a strong
indicator for a binary.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-26 09:04:01 +02:00
Sebastian Martinez 9b15911f83 Use lastCommit of each blob for navigation instead of patch revision
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-25 10:07:14 +02:00
Sebastian Martinez b47609a06e httpd: Add routes for handling embeds in issues
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 10:00:01 +02:00
Sebastian Martinez fb06b5fe8b Add moved and copied files e2e tests
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:50:27 +02:00
Alice Liddell 1b01216bf8 Improve FileDiff and add tests
Signed-off-by: Alice Liddell <alice@radicle.xyz>
2023-09-19 07:49:36 +02:00
Sebastian Martinez ee9cb2b0d7 Clean up some unnecessary types
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:49:36 +02:00
Sebastian Martinez 217d8b2dd4 Add base diffChangeset schema and extend for other schemas
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:49:36 +02:00
Sebastian Martinez 00905afea4 Add DiffContent type to @httpd-client
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:49:36 +02:00
Sebastian Martinez ca6762fc95 Refactor commit and diff types, updates outdated diff types
- Adds support for modified moved files see https://github.com/radicle-dev/radicle-git/pull/141

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:49:36 +02:00
Sebastian Martinez afab097d09 Delay global hotkeys tiping speed to imitate real user
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:45:40 +02:00
Sebastian Martinez 1a7c28b6ea Split going through UI patch flow into separate tests
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-19 07:45:40 +02:00
Sebastian Martinez 800a9767d6 Update heartwood version
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-18 23:38:13 +02:00
Sebastian Martinez 9c533cdea8 httpd: Add node alias to session endpoints
This will allow us to show the alias of an authenticated user in the web
client.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-18 11:18:17 +02:00
Sebastian Martinez fe753d898d Update radicle-surf to v0.15.0
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-18 10:57:37 +02:00
Sebastian Martinez a650c37383 Add alias to session payload
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-16 07:00:08 +02:00
Sebastian Martinez c92e593a16 Fix vite reloading during e2e tests
The issue seems to have been linked to the fact that we triggers incorrect refresh
through fsEvents. Even tough there are no changes on the local file system,
it requests full reload after 1-2 min.

Disabling fsEvents in the vite.config.ts prevents this to happen and per extension,
avoid the problem.

source: https://stackoverflow.com/a/75238360

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-13 15:15:44 +02:00
Sebastian Martinez 127c1d228d Add requirement section for version of Safari and Node
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-08 09:42:16 +02:00
cloudhead 53ccce34b1 cob: Add missing verdict field to review.edit
This is generally useful, and required when constructing a review
without knowing the verdict ahead of time.
2023-09-05 11:17:59 +02:00
Sebastian Martinez 45830f6cd9 Show local projects instead of network to landing page, if available
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-04 12:06:03 +02:00
Sebastian Martinez 4947ac48a3 httpd: Return entire files in diff endpoint
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-09-02 19:02:25 +02:00
cloudhead 05f75f2c02 httpd: Better error output from git backend 2023-09-01 15:17:41 +02:00
cloudhead b96fbac3f0 httpd: Try lowercase READMEs as well 2023-09-01 15:17:41 +02:00
cloudhead 7a641aead5 httpd: Fix clippy warning
Note: because we don't have a working copy here, we can't call
`Merged::cleanup`. We need to figure something out for this.
2023-09-01 15:16:56 +02:00
cloudhead d565a039e4 node: Implement private repos
Private repos are implemented by extending the identity document with a
`visibility` attribute, that can either be `"public"` (default) or
`"private"`.

In case of `private` visibility, only the delegates are allowed to view
the repo, as well as any DIDs added to the allow list.

To implement repo visibility, we simply block fetches from and
announcements to peers for whom the repo should remain invisible.

Private repos are also not announced in the `inventory` message, since
the full list of peers that *may* have the repo is retrievable from the
repo identity. This could cause errors if eg. a peer who is allowed to
view the repo doesn't actually have it. However this is an ok trade-off
for now to keep the complexity low. For repos to truly be private, it's
important that the RIDs don't leak either.

Finally, we modify `radicle-httpd` for now to only list public repos.
Eventually, we would want to change this depending on whether an allowed
peer is authenticated with the service or not.

---

It's also worth mentioning why this approach was taken, vs. end-to-end
encryption. The reasons are as follows:

1. Nodes that do not have access to a private repo will generally not want to
   replicate encrypted data that they cannot examine or use.
2. The chosen solution is trivial, while encrypting git objects isn't.
3. Performance of the chosen solution is much better, there is no
   overhead.
4. Privacy of the chosen solution is better: RIDs are never leaked, and
   neither is the existence of a private repo, nor who has access to it.

There is one downside: Paying for storage of private repos is no better
in terms of privacy than what GitHub offers. Hosting providers will have
access to your private repos, if this solution is used.
2023-09-01 12:13:45 +02:00
Sebastian Martinez 542630a7f7 Add patch comment and state modifiers
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-30 17:05:25 +02:00
Vincenzo Palazzo e9da55c8a7 httpd: Enable the clock feature in chrono
Currently, radicle-httpd does not compile without this.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-08-29 11:33:39 +02:00
Sebastian Martinez aec0289f10 Refactor some of the reaction components
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:52:57 +02:00
Sebastian Martinez 26447b3c59 Switch edit title button with icons
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-08-28 13:34:57 +02:00
Rūdolfs Ošiņš 3bd13196d9 Add icons to browser file tree
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-08-28 12:03:19 +02:00