Commit Graph
2316 Commits
Author SHA1 Message Date
Rūdolfs OšiņšandThomas Scholtes 391f188b69 Fix navigating to history when a file is selected
Co-authored-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-26 14:17:18 +02:00
Sebastian Martinez a0c578604e httpd: Add commit parents vector to /commits/:sha endpoint
So we can act upon the eventual parents of a commit, after fetching a
single commit we need to have the parents of that commit as part of the
json payload.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-26 13:21:31 +02:00
Rūdolfs Ošiņš b5980a12ac Update dependencies
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-26 10:36:50 +02:00
Rūdolfs Ošiņš 653bacd8d0 Replace deprecated substr with substring
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-25 17:20:38 +02:00
Rūdolfs Ošiņš 69d2f9bff9 Make issues/patches tab counters reactive
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-25 15:47:06 +02:00
Alexis Sellier 1dc799d679 cob: Remove CRDTs from COB state
It turns out that the CRDT formed by the union of Git DAGs
is enough to guarantee everything we need for COBs.

This changes the following things:
* COB operations no longer need to be commutative
* COB histories are traversed in the same deterministic order on all
  replicas
* It's now possible to implement RSMs on top of COBs, eg. scripting
* Lamport clocks have been removed
* `radicle-crdt` is no longer a dependency of `radicle`
* COBs are no longer instances of `Semilattice`
* The `Ops` type was removed in favor of having `Op` contain multiple
  actions
2023-07-25 15:29:27 +02:00
xphoniex 2e25250be4 httpd: Add a cache for /tree
This improves response time of:

- GET /api/v1/projects/<RID>/tree/<OID>/ from 205.71ms down to 376.4µs
- GET /api/v1/projects/<RID>/tree/<OID>/.nix from 111.06ms down to 351.70µs

Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-25 13:10:58 +02:00
Sebastian Martinez 3fcadc5058 httpd: Fix commit count in repo stats in history route
Instead of using always the repo HEAD for the commit count with
`repo::stats` we should use `repo::stats_from` and pass the `parent`
commit.

This way we allow e.g. a commit history for a peer with lesser commits
to be counted correctly.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-25 12:34:03 +02:00
xphoniex ed62ac4264 Add -h flag to binaries
Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-25 11:58:39 +02:00
Thomas Scholtes 8f4b788a65 Simplify SourceBrowsingHeader props
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-25 11:56:33 +02:00
Thomas Scholtes afbdf2f041 Introduce TreeView and HistoryView
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-25 11:56:33 +02:00
Rūdolfs Ošiņš 251d97cdde Load issue list in project router
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-25 11:33:52 +02:00
Rūdolfs Ošiņš fbe133cd95 Load patch list in project router
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-25 11:32:28 +02:00
Thomas Scholtes 1b6bed73a6 Lift branch/peer selector data into main views
We prepare the data for `PeerSelector` and `BranchSelector` in the
`History` and `Browser` instead of `SourceBrowsingHeader`. This makes
the component APIs overall simpler and allows us to remove
`LoadedSourceBrowsingView`.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-24 14:25:53 +02:00
Thomas Scholtes 9c1392598a Simplify BranchSelector
There’s no need for the outer `if branches.length > 0`. We already
disable the dropdown unless `branches.length > 1`.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-24 14:10:26 +02:00
Thomas Scholtes 29e3295f45 Represent issue status filter in route
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-24 12:15:35 +02:00
Thomas Scholtes dd7f3a850e Simplify project route loading
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-24 12:15:35 +02:00
Sebastian Martinez f631c7f171 Fix absolute links with files in markdown
We had a regression because of introducing marked-linkify-it, which took
links for CONTRIBUTING.md or HACKING.md as domains of a new page instead
than files to be navigating to.

This commit sets the `fuzzyLink` option for marked-linkify-it to false,
which disables this behavior

Also tests that the browser tree expands itself when navigating to a
file inside a directory

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-22 08:02:00 +02:00
Sebastian Martinez 50d046ce86 Fix URL not updating when using navigateInternalOnAnchor
We were always calling `replace` and not passing the desired action in
the `navigateInternalOnAnchor`, this was leading to the URL not updating
when e.g. clicking on file URLs in Markdown renders.

By passing the action to the `navigate` fn instead we can also take the
`push` action into account.

Test have been written to guarantee this works

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-21 22:36:53 +02:00
Thomas Scholtes b76db5dfa3 Remove source browsing header from commit view
For a single commit view the source browsing header (peer selector,
branch selector, commits, contributor count) does not contain meaningful
information. We remove the header and simply show the commit.

See #938.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-20 17:14:12 +02:00
Thomas Scholtes c44cd5771b Fix movement of diff text when lines are selected
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-20 15:56:05 +02:00
xphoniex 5ee8c8281b Make diff line selectable and shareable
Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-20 11:37:57 +02:00
Alexis Sellier 7e211ab1df cli: Make key encryption optional
By leaving the passphrase prompt blank, users can create unencrypted
keys.
2023-07-20 10:40:15 +02:00
Sebastian Martinez 910f151c7f Update dependencies
Gets prettier to v3, which starts to write doctype in lowercase, see
https://prettier.io/blog/2023/07/05/3.0.0.html#print-html5-doctype-in-lowercase-7391httpsgithubcomprettierprettierpull7391-by-fiskerhttpsgithubcomfisker

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 16:32:37 +02:00
Thomas Scholtes aae50a2fda Use structured routing for patch views
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-19 15:14:53 +02:00
Thomas Scholtes fdd074fd13 Simplify BranchSelector and PeerSelector props
We greatly reduce the numbers of properties that need to be passed to
`BranchSelector` and `PeerSelector` by constructing routes in
`SourceBrowsingHeader`. We’ll lift the logic out of
`SourceBrowsingHeader` in a follow-up.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-19 15:00:39 +02:00
Sebastian Martinez afbc57079b Switch page.locator with page.getByRole and page.getByText
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 11:35:20 +02:00
Sebastian Martinez 6151729a6d Add empty file test case
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 11:35:20 +02:00
Sebastian Martinez e4a051b17a Add auto linking in Markdown components
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-19 09:07:01 +02:00
Sebastian Martinez 78b988af95 Replace custom extension with marked-katex-extension
- Add a visual test to check math rendering

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-17 17:18:07 +02:00
Thomas Scholtes fabd98fb57 Extract tree and history route loading
The `loadProjectRoute` function has become too big too understand. To
address this, we extract and separate the loading for the `tree` and
`history` views. This also gives us the opportunity to simplify some of
the code and parallelize more HTTP requests.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-17 15:48:37 +02:00
Sebastian Martinez 14ba807e55 Set the httpd port for the test suite to be 8081.
Also where possible use the `config.seeds.defaultHttpdPort` instead of
hardcoding it.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-17 15:19:31 +02:00
Sebastian Martinez 69946f5d8c Replace marked namespaces with Marked instance
Based on a new addition to marked, this commits replaces the imported
marked namespaces with a Marked class, that doesn't change when
`marked.use` introduces new options or extensions.

Also changes the naming slighty to use `markdown` as module, so it
sounds more generic.

Reference: https://github.com/markedjs/marked/pull/2831

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-17 14:47:53 +02:00
Thomas Scholtes 50088a5c8a Make pathToRoute tests more readable
We switch the test for `pathToRoute` from a paramterized test to regular
tests. I had a lot of trouble finding the right properties to change
when a test in this group failed. The line number was not helpful at all
and the test description was burried inside an object.

We also rename `pathToRoute` to `urlToRoute` because the function takes
a `URL` as an argument.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-17 11:44:27 +02:00
Thomas Scholtes 283b665b31 Switch to flat project route type
We switch to a project route type that is just a union. This has the
following advantages

* It’s much easier to construct project routes. Fewer properties are
  needed and there are no nested objects.
* We eliminate the implicitly shared properties `path`, `peer`,
  `revision` and `route` which only belonged to the tree route.
* The structure of the project route is more regular and thus easier to
  understand.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-17 11:27:57 +02:00
Alexis Sellier e41739187a Update radicle-surf and git-ref-format 2023-07-14 16:57:55 +02:00
Thomas Scholtes 684700a24d Don’t flood Playwright traces with route.continue()
We determine URLs to mock with a URL matcher instead of mocking every
URL and determining the behavior in the route handler. This should be
slightly faster and should result in better debugging experience because
we don’t come across the `route.continue()` event that often.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-14 09:29:19 +02:00
Thomas Scholtes f80b193bbd Don’t intercept navigation to external URLs in Markdown
Fixes 928

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-14 09:29:19 +02:00
Rūdolfs Ošiņš b797c6a3f7 Reverse revision commit ordering
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-14 09:26:34 +02:00
Rūdolfs Ošiņš cdd0b9c7b6 Set page title in the router
This improves UX making it easier to find the tab that I'm looking for
when I have multiple tabs open.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
2023-07-14 08:38:15 +02:00
Thomas Scholtes d0ee6e42e6 Simplify ProjectLoadedView
We simplify some of the choices for `ProjectLoadedView` by reducing the
nesting and removing redundant properties.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-12 15:59:46 +02:00
Sebastian Martinez 205fc814bc Bring reactions to comments and issues
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 15:36:02 +02:00
Sebastian Martinez 28718ba0cf Add --alias to rad auth
To avoid the popping up of a terminal input field during the
globalFixture setup, we need to pass the wanted alias as a flag.

Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 15:36:02 +02:00
Sebastian Martinez 6e3bcc1998 Update heartwood version
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 15:36:02 +02:00
Thomas Scholtes d0a280be02 Simplify project route resolving
Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-12 15:24:06 +02:00
Thomas Scholtes 9dd3af0f9f Cleanup shared peer and revision props for project route
We move the `peer` and `revision` properties from the shared
`ProjectLoadedParams` interface to the `tree` and `history` subroutes
where they are needed.

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
2023-07-12 15:15:39 +02:00
xphoniex 08a5a329c3 Use correct tree hash for file path on diff page
Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-12 14:43:50 +02:00
xphoniex 5db94a962d Show "Empty file" when diff is plain without hunks
Signed-off-by: xphoniex <dj.2dixx@gmail.com>
2023-07-12 14:16:54 +02:00
Alexis Sellier ac8112a9a0 Don't fail if we can't open the database
We make sure that even if there is no database file, we're still able
to return `None` for the alias lookup.
2023-07-12 11:37:20 +02:00
Sebastian Martinez 3cf5563c09 Run httpd-api unit tests with multiple threads
Signed-off-by: Sebastian Martinez <me@sebastinez.dev>
2023-07-12 10:58:46 +02:00