Start e2e specs at a route that exists

/repos is no longer a route, so specs fell back to the inbox and logged a
routing error. The inbox opens the first-launch guide, so tests now start
with it dismissed. The router now logs the URL it couldn't resolve
instead of just "URL".
This commit is contained in:
Rūdolfs Ošiņš
2026-10-01 18:16:29 +02:00
parent b0fcde4d4b
commit 7728c9272e
7 changed files with 14 additions and 11 deletions
+1 -1
View File
@@ -87,7 +87,7 @@ async function navigateToUrl(
if (route) {
await navigate(action, route);
} else {
console.error("Could not resolve route for URL: ", url);
console.error(`Could not resolve route for URL: ${url.href}`);
await navigate(action, { resource: "inbox" });
}
}
+1 -1
View File
@@ -10,7 +10,7 @@ test("copy to clipboard", async () => {
await context.grantPermissions(["clipboard-read", "clipboard-write"]);
const page = await context.newPage();
await page.goto("/repos");
await page.goto("/inbox");
// Reset system clipboard to a known state.
await page.evaluate<string>("navigator.clipboard.writeText('')");
-3
View File
@@ -36,9 +36,6 @@ async function openIssues(page: Page) {
}
async function launch(page: Page) {
await page.addInitScript(() =>
localStorage.setItem("appFirstLaunch", "false"),
);
await page.goto("/inbox");
await expect(page.getByRole("link", { name: "cobs" })).toBeVisible();
}
+2 -2
View File
@@ -8,7 +8,7 @@ test("navigate single issue", async ({ page }) => {
});
test("correct order of threads", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await page.getByRole("link", { name: "cobs" }).click();
await page.getByRole("link", { name: "Issues" }).click();
await page.getByText("This title has **markdown**").click();
@@ -29,7 +29,7 @@ test("correct order of threads", async ({ page }) => {
});
test("creation of top level comments", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await page.getByRole("link", { name: "cobs" }).click();
await page.getByRole("link", { name: "Issues" }).click();
await page.getByRole("button", { name: "New" }).click();
+1 -1
View File
@@ -1,7 +1,7 @@
import { expect, test } from "@tests/support/fixtures.js";
test("navigate to repo issues", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await page.getByRole("link", { name: "cobs" }).click();
await page.getByRole("link", { name: "Issues" }).click();
await page.getByText("This title has **markdown**").click();
+3 -3
View File
@@ -1,13 +1,13 @@
import { expect, reload, test } from "@tests/support/fixtures.js";
test("default theme", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await expect(page.locator("html")).toHaveAttribute("data-theme", "dark");
});
test("theme persistence", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await expect(page.getByRole("link", { name: "markdown" })).toBeVisible();
await page.getByRole("button", { name: "Settings" }).click();
@@ -20,7 +20,7 @@ test("theme persistence", async ({ page }) => {
});
test("change theme", async ({ page }) => {
await page.goto("/repos");
await page.goto("/inbox");
await expect(page.getByRole("link", { name: "markdown" })).toBeVisible();
await page.getByRole("button", { name: "Settings" }).click();
+6
View File
@@ -34,6 +34,12 @@ export const test = base.extend<{
}>({
forAllTests: [
async ({ outputLog, page }, use) => {
// Otherwise the app opens the guide on its first launch, depending on
// how fast startup is.
await page.addInitScript(() =>
localStorage.setItem("appFirstLaunch", "false"),
);
const browserLabel = logLabel.logPrefix("browser");
page.on("console", msg => {
// Ignore common console logs that we don't care about.